Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 컨텐츠 전체 조회 API 헤더에 중국어, 일본어 추가 #284

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

leeeeeyeon
Copy link
Contributor

🛰️ Issue Number

#283

🪐 작업 내용

중국어와 일본어 컨텐츠를 추가함에 따라 Content-Language 헤더에서 cn(중국어)와 jp(일본어)를 추가했습니다.

👋 리뷰어가 중점적으로 확인해야 할 것 (Optional)

X

🔬 테스트 코드 결과

image

✅ Check List

  • 코드가 정상적으로 컴파일되나요?
  • 테스트 코드를 통과했나요?
  • merge할 브랜치의 위치를 확인했나요?
  • Reviewer를 지정했나요?
  • Assignee를 지정했나요?
  • Label을 지정했나요?

@leeeeeyeon leeeeeyeon added the ☁️ feature New feature or request label Nov 20, 2023
@leeeeeyeon leeeeeyeon requested a review from yth01 November 20, 2023 07:58
@leeeeeyeon leeeeeyeon self-assigned this Nov 20, 2023
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #284 (4b99e60) into develop (9cf84e9) will decrease coverage by 0.26%.
Report is 6 commits behind head on develop.
The diff coverage is 37.73%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #284      +/-   ##
=============================================
- Coverage      47.62%   47.36%   -0.26%     
- Complexity       369      379      +10     
=============================================
  Files            100      103       +3     
  Lines           1976     2029      +53     
  Branches          54       56       +2     
=============================================
+ Hits             941      961      +20     
- Misses          1017     1048      +31     
- Partials          18       20       +2     
Files Coverage Δ
...om/gsm/blabla/content/api/ContentControllerV2.java 50.00% <50.00%> (ø)
...a/com/gsm/blabla/global/config/P6SpyFormatter.java 83.33% <83.33%> (ø)
...ain/java/com/gsm/blabla/global/util/LogAspect.java 23.07% <23.07%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83ecef5...4b99e60. Read the comment docs.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@leeeeeyeon leeeeeyeon merged commit 1d890b0 into develop Nov 20, 2023
3 of 4 checks passed
yth01 pushed a commit to yth01/blabla-server that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☁️ feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant