Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist: Guilded & Other Discord Alternative Builds #972

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

Alm0stEthical
Copy link
Contributor

Hi @dbuechel,

Some kids in my class were using Discord Bots, which they programmed themselves, to play MP3 files (through a Discord Bot) in the background so they could cheat during the test. I’ve added Discord PTB (DiscordPTB.exe) and Canary (DiscordCanary.exe) builds to the blacklist as well, since only the main Discord (Discord.exe) build was previously blacklisted. Guilded is also similar to Discord and functions basically the same as Discord.

So, this PR will fix the issue and prevent cheating.

Cheers,
David Tanasescu
https://davidtanasescu.com/

Copy link

codecov bot commented Sep 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.49%. Comparing base (7029b12) to head (00180a9).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #972      +/-   ##
==========================================
- Coverage   55.53%   55.49%   -0.05%     
==========================================
  Files         224      224              
  Lines       13430    13433       +3     
  Branches     1467     1467              
==========================================
- Hits         7459     7455       -4     
- Misses       5653     5658       +5     
- Partials      318      320       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alm0stEthical
Copy link
Contributor Author

Hi, I intended to create a new PR for the locales, but for some reason, it got added here by mistake. Sorry about that! By the way, my native language is Dutch, and I’m bilingual in Romanian.

@dbuechel
Copy link
Member

Thanks for your contribution! Permitted and prohibited applications can always be altered and extended for any particular SEB configuration, but we'll gladly take up your suggestions into our default list of prohibited applications. And we'll most definitely incorporate the Romanian translation, much appreciated!

At the moment, we're busy with wrapping up the next release version 3.8.0, but we'll come back, review and merge your pull request as soon as time permits.

@Alm0stEthical
Copy link
Contributor Author

Thanks for your contribution! Permitted and prohibited applications can always be altered and extended for any particular SEB configuration, but we'll gladly take up your suggestions into our default list of prohibited applications. And we'll most definitely incorporate the Romanian translation, much appreciated!

At the moment, we're busy with wrapping up the next release version 3.8.0, but we'll come back, review and merge your pull request as soon as time permits.

Thank you, for your kind words and consideration! I'm glad the suggestion regarding the blacklist of Discord builds and Guilded was helpful, and I appreciate your willingness to include it in the default list of prohibited applications.

I'm also happy to hear that the Romanian translation will be added. I understand you're focused on the upcoming release, so I'll patiently await the review and merge of this PR whenever you have time.

Thanks again!
Cheers,
David Tanasescu
https://davidtanasescu.com/

Copy link
Member

@dbuechel dbuechel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, it is much appreciated!

@dbuechel dbuechel merged commit 2844a7a into SafeExamBrowser:master Oct 25, 2024
2 of 3 checks passed
@dbuechel
Copy link
Member

You can test your changes and the new translation in the latest beta build of version 3.9.0: https://sebdev.ethz.ch/api/buildjobs/l9vhvbnt819i9a3q/artifacts/SEB_3.9.0.754_SetupBundle.exe.

@dbuechel
Copy link
Member

dbuechel commented Nov 7, 2024

@Alm0stEthical I have just today found out that the Romanian translation wasn't integrated correctly. I have fixed this, now it should work and be testable in the latest beta build of version 3.9.0: https://sebdev.ethz.ch/api/buildjobs/sqhaka4faqvbyijj/artifacts/SEB_3.9.0.758_SetupBundle.exe.

@Alm0stEthical
Copy link
Contributor Author

@Alm0stEthical I have just today found out that the Romanian translation wasn't integrated correctly. I have fixed this, now it should work and be testable in the latest beta build of version 3.9.0: https://sebdev.ethz.ch/api/buildjobs/sqhaka4faqvbyijj/artifacts/SEB_3.9.0.758_SetupBundle.exe.

Yup, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants