Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UT-5331] Bump PROTO_C version in Dockerfile #168

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[UT-5331] Bump PROTO_C version in Dockerfile #168

merged 1 commit into from
Oct 8, 2024

Conversation

chavdarch
Copy link
Contributor

Summary

Problem description

Pros/cons of approach implemented

Checklist

  • Is this PR a reasonable size?
  • List deployment sequence with all relevant PRs.
    • ...

Code Review Guidelines for Reviewers

  • Try to review in a timely manner. Opinions/nitpicks should not be blockers. Pair on a call for non-trivial feedback.
  • Overall design and approach should follow established patterns. Don't try to make the PR perfect.
  • Try to identify edge cases, race conditions, over-engineering, lack of test coverage and complexity.
  • If you don't feel qualified to review the code, pass it on to someone who is.

@chavdarch chavdarch requested a review from a team as a code owner October 8, 2024 03:31
@chavdarch chavdarch merged commit 2f715c7 into main Oct 8, 2024
9 checks passed
@chavdarch chavdarch deleted the UT-5331_reject_over_break branch October 8, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc-peter sc-peter sc-peter approved these changes

@HarryTranAU HarryTranAU HarryTranAU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chavdarch @HarryTranAU @sc-peter