Drop base64 dependency
#118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Ruby 3.4 this isn't a default gem anymore
|
Thank you! Looks good. I definitely need to gain more experience with |
|
thanks! |
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Jun 25, 2024
rubocop#13002 SamSaffron/memory_profiler#118 This causes issues in CI since it accidentally added a dependency on base64 The next release will fix that error
Earlopain
added a commit
to Earlopain/rubocop
that referenced
this pull request
Jun 25, 2024
rubocop#13002 SamSaffron/memory_profiler#118 This causes issues in CI since it accidentally added a dependency on base64 The next release will fix that error
|
@SamSaffron, would you mind creating a release with this? Ruby 3.4 is coming ever-closer and the warning is annoying 🙃 |
|
sure will push a gem today. |
|
Thanks, I appreciate that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in #116. On Ruby 3.4 this isn't a default gem anymore and will lead to errors when trying to require it. There are slightly more unintuitive "aliases" in the
pack/unpackmethods.I don't believe the url escaping is actually needed. All it does is replace
+with-and/with_.cc @fatkodima