Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rate limiting in /sendOTP api #86

Merged
merged 2 commits into from
Sep 21, 2023
Merged

add rate limiting in /sendOTP api #86

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cc3d1b
add throttle in /sendOTP api
yuvrajsab Sep 20, 2023
1bffb7d
bump requests number
yuvrajsab Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/api/api.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@ import {
Param,
Patch,
Post,
Query, UnprocessableEntityException, UseInterceptors, UsePipes, ValidationPipe,
Query,
UnprocessableEntityException,
UseInterceptors,
UsePipes,
ValidationPipe,
} from '@nestjs/common';
import {
SignupResponse,
Expand All @@ -26,6 +30,7 @@ import * as Sentry from '@sentry/node';
import { LoginDto } from './dto/login.dto';
import { SendOtpDto } from './dto/send-otp.dto';
import { VerifyOtpDto } from './dto/verify-otp.dto';
import { Throttle } from '@nestjs/throttler';
// eslint-disable-next-line @typescript-eslint/no-var-requires
const CryptoJS = require('crypto-js');

Expand All @@ -49,6 +54,7 @@ export class ApiController {
};
}

@Throttle(10, 60)
@Get('sendOTP')
@UsePipes(new ValidationPipe({ transform: true }))
async sendOTP(
Expand All @@ -68,10 +74,12 @@ export class ApiController {
Sentry.captureMessage('Phone number not registered', {
user: {
username: params.phone,
applicationId: applicationId
}
applicationId: applicationId,
},
});
throw new UnprocessableEntityException(params.errorMessage ?? 'User not found.');
throw new UnprocessableEntityException(
params.errorMessage ?? 'User not found.',
);
}
}
const status: SMSResponse = await this.otpService.sendOTP(params.phone);
Expand Down Expand Up @@ -252,7 +260,7 @@ export class ApiController {
@Headers('authorization') authHeader,
@Headers('x-application-id') applicationId,
): Promise<UsersResponse> {
const queryString = `(id: ${userId})`; // pass the strict user ID filter
const queryString = `(id: ${userId})`; // pass the strict user ID filter
return await this.apiService.fetchUsersByString(
queryString,
undefined,
Expand Down
Loading