-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deleted .env
file and added a new sample.env
file
#49
base: main
Are you sure you want to change the base?
fix: deleted .env
file and added a new sample.env
file
#49
Conversation
Hi @SanjaySinghRajpoot thank you for the contribution. We also have a e2e gitpod setup for workflow. You will have to create a .env from this sample.env in the setup steps of gitpod. Take a look at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, automate creating a .env using sample.env in .gitpod.yml setup.
I have made the changes, please check. |
Thanks for the changes @SanjaySinghRajpoot, can you also copy the .env values to sample.env as well. We can then integrate the rotate secrets script later. PS: Please Join the discord as welll for easier communication. You can ping your PRs waiting for review there. |
I have updated the PR please check. |
# GQL | ||
HASURA_GRAPHQL_ADMIN_SECRET=myadminsecretkey | ||
HASURA_GRAPHQL_JWT_SECRET=529845d36519367203a8bbf5a0942ef4 | ||
HASURA_GRAPHQL_DATABASE_URL=43034095d6066ab71c39d69d5b665d6a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Databse URL is not supposed to be a random string.
|
||
# GQL | ||
HASURA_GRAPHQL_ADMIN_SECRET=myadminsecretkey | ||
HASURA_GRAPHQL_JWT_SECRET=529845d36519367203a8bbf5a0942ef4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JWT Secret is a URL to .well-known of FusionAuth
POSTGRES_PASSWORD=4a59d9a4f8b26b1a37b1307522dbee13 | ||
DATABASE_USERNAME=e3adcb5f0ea9f9fabeef700dd1829062 | ||
DATABASE_PASSWORD=adbbd84663d621d2c61a83511afbd586 | ||
ES_JAVA_OPTS=b057fb1de7f0c4bfa9e3a47bfc5dddef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the memory configuration for JVM
@SanjaySinghRajpoot you have ran the script on all the variables. Not all variables are supposed to be rotated. Please re-verify from .env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the environment variables
Description
I have deleted the
.env
file and added a newsample.env
file.Fixes #42
Changes
Added a new
.env
file and deleted the existing file.