Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deleted .env file and added a new sample.env file #49

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SanjaySinghRajpoot
Copy link

@SanjaySinghRajpoot SanjaySinghRajpoot commented May 8, 2023

Description

I have deleted the .env file and added a new sample.env file.

Fixes #42

Changes

Added a new .env file and deleted the existing file.

@tushar5526
Copy link
Member

Hi @SanjaySinghRajpoot thank you for the contribution. We also have a e2e gitpod setup for workflow. You will have to create a .env from this sample.env in the setup steps of gitpod. Take a look at .gitpod.yml, let me know if you need more clarification.

Copy link
Member

@tushar5526 tushar5526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, automate creating a .env using sample.env in .gitpod.yml setup.

@SanjaySinghRajpoot
Copy link
Author

I have made the changes, please check.

@tushar5526
Copy link
Member

tushar5526 commented May 16, 2023

Thanks for the changes @SanjaySinghRajpoot, can you also copy the .env values to sample.env as well. We can then integrate the rotate secrets script later.

PS: Please Join the discord as welll for easier communication. You can ping your PRs waiting for review there.

@SanjaySinghRajpoot
Copy link
Author

I have updated the PR please check.

# GQL
HASURA_GRAPHQL_ADMIN_SECRET=myadminsecretkey
HASURA_GRAPHQL_JWT_SECRET=529845d36519367203a8bbf5a0942ef4
HASURA_GRAPHQL_DATABASE_URL=43034095d6066ab71c39d69d5b665d6a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Databse URL is not supposed to be a random string.


# GQL
HASURA_GRAPHQL_ADMIN_SECRET=myadminsecretkey
HASURA_GRAPHQL_JWT_SECRET=529845d36519367203a8bbf5a0942ef4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JWT Secret is a URL to .well-known of FusionAuth

POSTGRES_PASSWORD=4a59d9a4f8b26b1a37b1307522dbee13
DATABASE_USERNAME=e3adcb5f0ea9f9fabeef700dd1829062
DATABASE_PASSWORD=adbbd84663d621d2c61a83511afbd586
ES_JAVA_OPTS=b057fb1de7f0c4bfa9e3a47bfc5dddef
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the memory configuration for JVM

@tushar5526
Copy link
Member

@SanjaySinghRajpoot you have ran the script on all the variables. Not all variables are supposed to be rotated. Please re-verify from .env

Copy link
Member

@tushar5526 tushar5526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the environment variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove .env and provide a sample.env
2 participants