Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes : Validation , Export Button, Back Button #83

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Conversation

Harshil-Jani
Copy link
Collaborator

@Harshil-Jani Harshil-Jani commented Oct 28, 2022

Description

Continuing from the comments of #59 and #62

  • Fixed Esamwaad UserName and FullName Validation in Create and Edit.
  • Fixed Back Button in Shiksha UserCreate.
  • Disallowing export from the Shiksha List.

Changes

List the changes done to fix a bug or introducing a new feature.

How to test

Describe the steps required to test the changes proposed in the pull request.

Please consider using the closing keyword if the pull request is proposed to
fix an issue already created in the repository
(https://help.github.com/articles/closing-issues-using-keywords/)

@Harshil-Jani Harshil-Jani changed the title Fixes : Authentication , Export Button, Back Button Fixes : Validation , Export Button, Back Button Oct 28, 2022
@Shruti3004 Shruti3004 merged commit 42f5892 into master Oct 28, 2022
Shruti3004 added a commit that referenced this pull request Oct 31, 2022
Co-authored-by: Harshil Jani <harshiljani2002@gmail.com>
Shruti3004 added a commit that referenced this pull request Nov 1, 2022
* Fixes : Authentication , Export Button, Back Button (#83)

* Fix: Location, Shiksha Tabs (#85)

* fix : Location Tab

* fix : Shiksha Mobile Number

* fix: Roles filter

Co-authored-by: Harshil Jani <harshiljani2002@gmail.com>
@Harshil-Jani Harshil-Jani deleted the fixing-tabs branch November 1, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants