Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in HasCustomAttribute affecting performance #405

Merged

Conversation

ds5678
Copy link
Contributor

@ds5678 ds5678 commented Dec 25, 2024

The rangeIndex was frequently negative, causing numerous exception throws that got immediately caught.

AttributeTypes was null for injected objects and was throwing a null reference exception when we tried to enumerate it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12490924222

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 27.496%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Cpp2IL.Core/Model/Contexts/HasCustomAttributes.cs 0 4 0.0%
Totals Coverage Status
Change from base Build 12482389175: -0.01%
Covered Lines: 3360
Relevant Lines: 10400

💛 - Coveralls

@SamboyCoding SamboyCoding merged commit 5a919d9 into SamboyCoding:development Dec 25, 2024
6 checks passed
@ds5678 ds5678 deleted the hascustomattributes-bugs branch December 25, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants