-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for updating Drifty #316
Conversation
# Conflicts: # .idea/misc.xml # src/main/java/CLI/Main.java # src/main/java/GUI/Forms/Main.java # src/main/java/Utils/DriftyConstants.java
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! You did it 🎉 Now, Relax 😉, Grab a drink ☕, and wait for the maintainers to check your contributions. Meanwhile, you can discuss on other issues and solve them 😀. Thank You 😃!
Meanwhile you can also discuss about the project in our Discord Server 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmr-rohit Please do not commit any executables.
The requested changes have been made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmr-rohit The updater will be an isolated class in a separate package. Please check the below steps that drifty will follow for updating :
- Check if update is available
- If yes, download it according to the OS
- Download the updater (this will contain the Updater class which will take two arguments - the current path along with executable name from which old drifty is running and the path where the latest executable has been downloaded; These will be command line arguments, and not direct passing of parameters)
- The old Drifty will exit and the updater will start
- The updater will replace the old one with the new one and it will start the new one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmr-rohit Please make the below requested changes.
Also, please note that the name of the updater executable built will be
- For windows ➡️
updater.exe
- For macOS ➡️
updater_macos
- For linux ➡️
updater_linux
and can be downloaded from:
- For windows ➡️
https://github.com/SaptarshiSarkar12/Drifty/releases/latest/download/updater.exe
- For Linux ➡️
https://github.com/SaptarshiSarkar12/Drifty/releases/latest/download/updater_linux
- For macOS ➡️
https://github.com/SaptarshiSarkar12/Drifty/releases/latest/download/updater_macos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have implemented the requested changes, please check and let me know if further any change is required. Thank You @SaptarshiSarkar12
@kmr-rohit This PR needs to be closed as no major changes have yet been made and there is a ton of conflicts which if resolved, does not help much. So, if you are interested in working on this issue, you need to open a separate PR. |
@kmr-rohit I am closing this PR because of inactivity. If you want to work on this, please reopen this PR. |
Fixes issue
Fixes #217
Changes proposed
Created Updater Package, Updated Main files for GUI & CLI, in order to check Updates and Download the latest available update using GitHub API.
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers
Summary by CodeRabbit
New Features
UPDATE
mode and related functionalities to the application.Updater
class for handling executable updates.Enhancements
Bug Fixes
Job
class.Refactor
Documentation
Style
Chores