Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(files): Send Files button from Share Files should be disabled if no user is selected #1298

Closed
luisecm opened this issue Oct 6, 2023 · 0 comments · Fixed by #1304
Closed
Assignees
Labels
bug 🐛 files 🗃️ Tickets that have to do with Files new ticket 💥

Comments

@luisecm
Copy link
Contributor

luisecm commented Oct 6, 2023

Description:
If you open the share files modal and select any file(s), but you do not select any user to share, you still can click the Send Files button. However no action is performed and modal is disabled.
However, if you go to share files, unselect the file you will see the send files button blocked. So I believe the button behavior should be consistent and be unclickable unless you can actually send files

Environment:
MacOS

Prerequisites:
Account created with friends and files uploaded

Steps to reproduce:

  1. Login with account with friends
  2. Go to files
  3. Right click on a file
  4. Select Share Files
  5. Make sure at least one file is selected and that no users are selected
  6. You will see the Send Files button can be clicked. Click on it and modal will be gone

Video:
https://github.com/Satellite-im/Uplink/assets/35935591/fc6fa225-d9be-43da-a189-0d7188c34571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 files 🗃️ Tickets that have to do with Files new ticket 💥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants