Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(chats): load the conversations on initialization and not do based on what is there in the state #1936

Closed
stavares843 opened this issue Mar 22, 2024 · 1 comment · Fixed by #1966
Assignees
Labels
assigned 💻 chat 📺 Tickets that have to do with chat improvement 🔨 medium priority Problems here should be completed at earliest convenience but can have others prioritized over it

Comments

@stavares843
Copy link
Member

task(chats): load the conversations on initialization and not do based on what is there in the state

@dariusc93
Copy link
Contributor

To clarify, uplink relies on the state to list the conversation(s), however if the state.json is deleted or corrupted (or if the account is being recovered in #1935), uplink would not show the conversations in the side bar. While it is possible to load up direct messages by clicking on the chat button with friends, it would not be possible to load group conversations from warp since uplink does not provide any means for that.

A solution would be :

  1. To exclude the conversation metadata from state.json and load the conversation into the state in memory.
  2. Initialize the conversation in the state if there been any update between what is in warp compared to the data in state.json

@dariusc93 dariusc93 added chat 📺 Tickets that have to do with chat medium priority Problems here should be completed at earliest convenience but can have others prioritized over it improvement 🔨 labels Mar 26, 2024
@Flemmli97 Flemmli97 self-assigned this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned 💻 chat 📺 Tickets that have to do with chat improvement 🔨 medium priority Problems here should be completed at earliest convenience but can have others prioritized over it
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants