Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(friends): Fix did hash for outgoing/incoming being reversed #1250

Merged
merged 10 commits into from
Oct 9, 2023
Merged

fix(friends): Fix did hash for outgoing/incoming being reversed #1250

merged 10 commits into from
Oct 9, 2023

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Fixes hash being displayed in reverse for outgoing/incoming friend requests.
    • Reason Identity#short_id is not used like in friend page is the short id is not present if the identity is not resolved fully

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Sep 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

461 tests   419 ✔️  1h 22m 48s ⏱️
  39 suites    42 💤
    3 files        0 ❌

Results for commit 1fa3e1d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2023 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Sep 28, 2023
@phillsatellite
Copy link
Contributor

Noticed one thing while testing, the did will still appear reversed in the blocked tab, this happens on all os's. Other than that seemed good!

Screenshot 2023-09-28 at 3 50 46 PM

@phillsatellite phillsatellite added the Changes requested When other dev or QA request a change label Sep 28, 2023
@Flemmli97 Flemmli97 removed the Changes requested When other dev or QA request a change label Sep 29, 2023
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Sep 29, 2023
@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Oct 2, 2023
@sdwoodbury sdwoodbury added the Changes requested When other dev or QA request a change label Oct 3, 2023
@github-actions github-actions bot added the missing fixing conflict A conflict exists in current PR and needs resolution label Oct 3, 2023
@Flemmli97 Flemmli97 removed missing fixing conflict A conflict exists in current PR and needs resolution Changes requested When other dev or QA request a change labels Oct 5, 2023
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Oct 5, 2023
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Oct 6, 2023
@stavares843 stavares843 added Waiting for CI Waiting for at least one CI job to complete before merging and removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Oct 6, 2023
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Oct 6, 2023
@dariusc93 dariusc93 merged commit feae633 into dev Oct 9, 2023
10 checks passed
@dariusc93 dariusc93 deleted the friend_hash_fix branch October 9, 2023 03:25
@github-actions github-actions bot removed the Waiting for CI Waiting for at least one CI job to complete before merging label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdwoodbury sdwoodbury sdwoodbury left review comments

@phillsatellite phillsatellite phillsatellite approved these changes

@lgmarchi lgmarchi lgmarchi approved these changes

@dariusc93 dariusc93 dariusc93 approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(friends): hash is displayed backwards
6 participants
@Flemmli97 @phillsatellite @dariusc93 @sdwoodbury @lgmarchi @stavares843