-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CropImageTool): Crop profile picture tool #1253
Conversation
Did you have similar problem on Linux @phillsatellite ? |
Was talking with Sara and Lucas this morning were thinking a better route is to get this merged in and create a new ticket for the Linux bug 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks functional but before approving I have some suggested improvements.
edit: the following got left out of the review - the eval
on line 49, which uses the first_render
hook - could be executed inside of an onmounted
event of the div
that starts on line 81.
I inserted inside use_future, it will run just one time as well. |
What this PR does 📖
1. Add possibility to crop image for profile picture
Screen.Recording.2023-09-28.at.14.35.15.mov
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤