Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cargo): Update dependency #1288

Merged
merged 6 commits into from
Oct 10, 2023
Merged

chore(cargo): Update dependency #1288

merged 6 commits into from
Oct 10, 2023

Conversation

dariusc93
Copy link
Contributor

@dariusc93 dariusc93 commented Oct 4, 2023

What this PR does 📖

  • Update dependency
  • Refactor logic when downloading attachments
  • Implemented MessageOptions::limit when fetching messages

Which issue(s) this PR fixes 🔨

  • N/A

Special notes for reviewers 🗒️

  • The change in the logic removes saving and downloaded attachments to constellation. This will be reimplemented in the near future
  • If there is no response when downloading an attachment, it will give an error. This will usually happen within 60 seconds but will reset if it continues to resolve.

Additional comments 🎤

@dariusc93 dariusc93 added the Draft PR is still a draft and needs more work label Oct 4, 2023
@dariusc93 dariusc93 self-assigned this Oct 4, 2023
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Oct 4, 2023
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Oct 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

UI Automated Test Results Summary for MacOS/Windows

461 tests   419 ✔️  1h 44m 9s ⏱️
  39 suites    42 💤
    3 files        0

Results for commit 57dd591.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

UI Automated Tests execution is complete! You can find the test results report here

@dariusc93 dariusc93 marked this pull request as ready for review October 5, 2023 13:52
@dariusc93 dariusc93 removed the Draft PR is still a draft and needs more work label Oct 5, 2023
@stavares843 stavares843 linked an issue Oct 6, 2023 that may be closed by this pull request
@dariusc93 dariusc93 added the Ready for testing Ready for QA to test label Oct 6, 2023
@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Oct 6, 2023
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Oct 6, 2023
@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Oct 6, 2023
@phillsatellite
Copy link
Contributor

Been testing with Sara. We both still got some errors when trying to download images from chat. For me the imagine never opens and says File is empty and cannot be opened and for Sara it didnt seem to be saving with the correct name

Captura_de_ecra_2023-10-06_as_19 57 46

@phillsatellite phillsatellite added Changes requested When other dev or QA request a change and removed Ready for testing Ready for QA to test labels Oct 6, 2023
@dariusc93
Copy link
Contributor Author

Been testing with Sara. We both still got some errors when trying to download images from chat. For me the imagine never opens and says File is empty and cannot be opened and for Sara it didnt seem to be saving with the correct name
Captura_de_ecra_2023-10-06_as_19 57 46

If the image or file havent been downloaded initially then the other peer would need to be online while attempting to download it. Also noticing the screenshot with the filename, that file would be impossible have since this PR also removes that snippet that caused the -20 in it. Was that produced from dev?

@dariusc93 dariusc93 added Ready for testing Ready for QA to test and removed Changes requested When other dev or QA request a change labels Oct 9, 2023
@stavares843 stavares843 removed the Ready for testing Ready for QA to test label Oct 9, 2023
@sdwoodbury sdwoodbury removed the Missing dev review Still needs to be reviewed by a dev label Oct 10, 2023
@phillsatellite phillsatellite added QA Tested QA has tested and approved and removed Ready for testing Ready for QA to test labels Oct 10, 2023
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Don't merge yet DO NOT MERGE labels Oct 10, 2023
@dariusc93 dariusc93 merged commit 61eaa51 into dev Oct 10, 2023
@dariusc93 dariusc93 deleted the chore/update/warp-r1 branch October 10, 2023 16:27
@github-actions github-actions bot removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

bug(files): Files are not downloading properly
4 participants