Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Disable share button if no chat selected #1304

Merged
merged 3 commits into from
Oct 10, 2023
Merged

fix(files): Disable share button if no chat selected #1304

merged 3 commits into from
Oct 10, 2023

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Disable the share button in files modal if no chat is selected

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Oct 10, 2023
@github-actions
Copy link
Contributor

UI Automated Test Results Summary for MacOS/Windows

356 tests   315 ✔️  1h 9m 3s ⏱️
  33 suites    39 💤
    3 files        1 ❌  1 🔥

For more details on these failures and errors, see this check.

Results for commit 3cb1a80.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@sdwoodbury sdwoodbury added Ready for testing Ready for QA to test and removed Missing dev review Still needs to be reviewed by a dev labels Oct 10, 2023
@stavares843 stavares843 added Waiting for CI Waiting for at least one CI job to complete before merging and removed Ready for testing Ready for QA to test Don't merge yet DO NOT MERGE Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Oct 10, 2023
@dariusc93 dariusc93 added the Ready to Merge This PR is ready to merge label Oct 10, 2023
@stavares843 stavares843 merged commit 33e066a into dev Oct 10, 2023
@stavares843 stavares843 deleted the share_files_button_fix branch October 10, 2023 17:08
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Ready to Merge This PR is ready to merge Waiting for CI Waiting for at least one CI job to complete before merging labels Oct 10, 2023
@stavares843 stavares843 removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stavares843 stavares843 stavares843 approved these changes

@sdwoodbury sdwoodbury sdwoodbury approved these changes

@dariusc93 dariusc93 dariusc93 approved these changes

Assignees

@Flemmli97 Flemmli97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(files): Send Files button from Share Files should be disabled if no user is selected
4 participants
@Flemmli97 @dariusc93 @sdwoodbury @stavares843