Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): adds a workflow to build linux in every PR #1365

Closed
wants to merge 3 commits into from

Conversation

stavares843
Copy link
Member

@stavares843 stavares843 commented Oct 20, 2023

What this PR does 📖

  • Adds a workflow to build linux in every PR to make sure it builds properly in each PR in Linux

image

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Oct 20, 2023
Copy link
Contributor

@WanderingHogan WanderingHogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use something like this: https://github.com/marketplace/actions/toml-reader to pull the toolchain value from cargo.toml?

@sdwoodbury
Copy link
Contributor

the cargo workflow runs/builds on linux already. Clippy will fail if the project won't compile. i believe this workflow is redundant.

@luisecm
Copy link
Contributor

luisecm commented Oct 21, 2023

the cargo workflow runs/builds on linux already. Clippy will fail if the project won't compile. i believe this workflow is redundant.

This means that the job that builds linux on automated tests is redundant too. I added this job recently just to ensure that app builds correctly on Linux. Since there are no automated tests for linux yet, I will add a PR to remove my build linux job too

@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Oct 21, 2023
@github-actions
Copy link
Contributor

UI Automated Test Results Summary for MacOS/Windows

296 tests   256 ✔️  1h 12m 10s ⏱️
  27 suites    40 💤
    3 files        0
    1 errors

For more details on these parsing errors, see this check.

Results for commit 8cdbcd0.

@github-actions
Copy link
Contributor

UI Automated Tests execution is complete! You can find the test results report here

@stavares843
Copy link
Member Author

got it, thanks! 🔨

@github-actions github-actions bot removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Oct 21, 2023
@stavares843 stavares843 deleted the sara/linux-pr-build branch November 1, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants