Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): Fix group typing indicator #1508

Merged
merged 5 commits into from
Nov 16, 2023
Merged

fix(chat): Fix group typing indicator #1508

merged 5 commits into from
Nov 16, 2023

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Fixes group typing indicator in sidebar

Which issue(s) this PR fixes 🔨

Copy link

coderabbitai bot commented Nov 13, 2023

Walkthrough

Walkthrough

The recent updates involve visual and functional enhancements to a user interface component that displays user images and typing indicators. The changes include a style modification for a user image element, improved conditional rendering logic for a user image group component to handle typing indicators and additional participants, and style adjustments for the typing indicator itself to ensure consistency and correct display.

Changes

File Path Change Summary
.../user_image/style.scss Changed background color from semi-transparent black to transparent.
.../user_image_group/mod.rs Updated UserImageGroup function to conditionally render typing indicators and handle additional participants.
.../user_image_group/styles.scss Adjusted .dot class dimensions and added .profile-typing class with z-index.

Assessment against linked issues (Beta)

Objective Addressed Explanation
Identify and resolve the sidebar typing indicator issue with 6 dots (1412) The changes in the mod.rs and styles.scss files suggest adjustments to the typing indicator rendering logic and styles, which likely address the issue.
Confirm the issue is specific to group messages (1412) The provided summary does not specify if the issue was confirmed to be specific to group messages, but the changes suggest a general improvement to the typing indicator.
Ensure typing indicator consistency across the application (1412) The style and functional changes in the mod.rs and styles.scss files are indicative of an effort to standardize the typing indicator's appearance.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Nov 13, 2023
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: .coderabbit.yaml

Commits Files that changed from the base of the PR and between 0f53424 and 61e3eaf.
Files selected for processing (3)
  • kit/src/components/user_image/style.scss (1 hunks)
  • kit/src/components/user_image_group/mod.rs (1 hunks)
  • kit/src/components/user_image_group/styles.scss (2 hunks)
Files skipped from review due to trivial changes (2)
  • kit/src/components/user_image/style.scss
  • kit/src/components/user_image_group/styles.scss

kit/src/components/user_image_group/mod.rs Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Nov 13, 2023

UI Automated Test Results Summary for MacOS/Windows

477 tests   364 ✔️  3h 2m 6s ⏱️
  41 suites  113 💤
    3 files        0

Results for commit 077d8d8.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 13, 2023

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Nov 14, 2023
@phillsatellite phillsatellite added Waiting for CI Waiting for at least one CI job to complete before merging QA Tested QA has tested and approved and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised Waiting for CI Waiting for at least one CI job to complete before merging labels Nov 14, 2023
@stavares843 stavares843 merged commit 360ebb4 into dev Nov 16, 2023
10 checks passed
@stavares843 stavares843 deleted the typing_indicator_fix branch November 16, 2023 18:46
@github-actions github-actions bot removed QA Tested QA has tested and approved Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(typing indicator): looks weird in the sidebar. possibly double rendered
5 participants