fix(OpenConsole): Fix open console on MacOS in developer mode

[lgmarchi]

What this PR does 📖

1. Fix open console on MacOS in developer mode

Screen.Recording.2023-11-13.at.22.59.17.mov

Which issue(s) this PR fixes 🔨

• Resolve bug(DeveloperMode): Open Console not working in MacOS #1505

Special notes for reviewers 🗒️

Additional comments 🎤

[coderabbitai]

Walkthrough

Walkthrough

The update involves modifying the webview configuration to include a JavaScript snippet that disables the right-click context menu. Additionally, a configuration method is introduced to control this behavior, which is set to false by default, indicating that the context menu is not disabled initially.

Changes

File	Change Summary
ui/src/webview_config.rs	Added JavaScript to disable right-click context menu; added with_disable_context_menu(false) method.

Assessment against linked issues (Beta)

Objective	Addressed	Explanation
1505: Ensure "Open Console" works on MacOS	❓	The changes do not directly reference the "Open Console" feature or MacOS-specific behavior, so it's unclear if the issue is addressed.

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• If you reply to a review comment from CodeRabbit, the bot will automatically respond.
• To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
• Note: Review comments are made on code diffs or files, not on the PR overview.
• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between f14407a and 38ac308.

Files selected for processing (1)

• ui/src/webview_config.rs (2 hunks)

Additional comments: 4

ui/src/webview_config.rs (4)

• 12-24: The JavaScript code block added to disable the context menu is a common approach for web applications that want to implement custom context menus or prevent the default browser context menu from appearing. However, it's important to ensure that this behavior is only active in developer mode, as it might confuse end-users if the context menu is disabled in production.

• 27-29: The drag event logging and handling seem appropriate. However, it's important to ensure that the DRAG_EVENT global state is thread-safe if it's being accessed from multiple threads. If DRAG_EVENT is a global mutable state, consider using synchronization primitives like mutexes to prevent data races.

• 31-31: The with_disable_context_menu(false) method call correctly sets the context menu to be enabled by default. This is a sensible default, but ensure that the method with_disable_context_menu is implemented correctly and that passing false indeed enables the context menu as intended.

• 33-34: This conditional block is checking for the Windows OS and production mode before setting the webview data directory. Ensure that similar handling is in place for MacOS, especially since the pull request is intended to address MacOS functionality.

[github-actions]

UI Automated Test Results Summary for MacOS/Windows

477 tests   364 ✔️  2h 54m 42s ⏱️
  41 suites  113 💤
    3 files        0 ❌

Results for commit 4f8ac30.

♻️ This comment has been updated with latest results.

[github-actions]

UI Automated Tests execution is complete! You can find the test results report here