feat(Files): Preview videos files in Storage and Chats #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and delete them when program starts
… profile and banner has been saved on temp_files now
… after close crop element
…on-when-viewing-image-in-chat' into 1692-taskchat-show-full-resolution-when-viewing-image-in-chat
github-actions
bot
added
Don't merge yet
…on-when-viewing-image-in-chat' into 1692-taskchat-show-full-resolution-when-viewing-image-in-chat
UI Automated Test Results Summary for MacOS/Windows552 tests 500 ✅ 3h 38m 52s ⏱️ Results for commit 50c88f5. ♻️ This comment has been updated with latest results. |
|
UI Automated Tests execution is complete! You can find the test results report here |
|
all the above was in macOS, m1 |
github-actions
bot
added
the
missing fixing conflict
github-actions
bot
added
linter failing
stavares843
requested changes
Jan 22, 2024
stavares843
added
Changes requested
lgmarchi
added
Ready for testing
github-actions
bot
removed
the
Failed Automated Test
stavares843
approved these changes
Jan 23, 2024
stavares843
added
QA Tested
dariusc93
approved these changes
Jan 23, 2024
dariusc93
added
Ready to Merge
github-actions
bot
removed
QA Tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
1. Preview videos
a. If is first time, and video is download with success: WIll be show a loader, and after that the video player will start with video
Screen.Recording.2024-01-15.at.10.05.18.mov
b. If is not first time previewing that file during app execution, it will load quick from cache and open video player with video without showing the loader
Screen.Recording.2024-01-15.at.10.07.21.mov
c. If take more than 10 seconds to download and load video, it will return a video player with error
Screen.Recording.2024-01-15.at.10.09.07.mov
2. Preview Image
a. If is first time, and image is downloaded with success: WIll be show a loader, and after that will open image in maximum quality
Screen.Recording.2024-01-15.at.11.13.58.mov
b. If is not first time previewing that image during app execution, it will load quick from cache and open image with maximum quality
c. If take more than 1.5 seconds to download and load image, it will return thumbnail of the image with lower quality
Screen.Recording.2024-01-15.at.11.14.59.mov
3. Cache
a. It will clear cache everytime app is closed or opened.
Screen.Recording.2024-01-15.at.10.11.00.mov
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤