-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(modal): Add conditional so modal will show for groups #1703
Conversation
Noticed a small bug that seems to be MacOS specific When I try to open the Members group chat model it doesnt seem to want to open. On Windows and Linux it works great Screen.Recording.2024-01-12.at.1.46.20.PM.mov |
…im/Uplink into view-modal-for-groups
UI Automated Tests execution is complete! You can find the test results report here |
Should be fixed! I'm not sure why but I think what was happening is that the other_participants() was referencing active_participants somehow. I'm not super familiar with how group structs work but that's my guess. Lemme know if you run into any problems, thank youuuuuu |
UI Automated Test Results Summary for MacOS/Windows484 tests 432 ✅ 2h 26m 55s ⏱️ Results for commit ee91fbf. ♻️ This comment has been updated with latest results. |
Hey dude! So I went back in and pulled the latest but still getting some funny behavior Its working great on Windows and Linux still but on Mac its about the same, 1on1 chats no longer have the group tooltip so thats working great but in group chats the members list still doesn't wanna open Mac: Mac.movWindows / Linux Windows.mp4 |
what phil mentioned also tried here and is the same 🔨 |
OY! Thank you for checking, I think I know what's up. If you are the creator of the group you get the edit button and not the modal, and vice versa if you are just added into the group, (not sure if you tried on accounts that were not admin of the group, it just messed me up for quite awhile so just putting it out there). This may be for not as Matt mentioned Saturday he may have an update for it anyways. |
closing after discussing with jeff as matt added this fix in another PR |
What this PR does 📖
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤