Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): Add conditional so modal will show for groups #1703

Closed
wants to merge 7 commits into from

Conversation

Jekrimo
Copy link
Contributor

@Jekrimo Jekrimo commented Jan 12, 2024

What this PR does 📖

  • Add a check to ensure more than two people are in a chat to only show modal in a group

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Jan 12, 2024
@phillsatellite
Copy link
Contributor

Noticed a small bug that seems to be MacOS specific

When I try to open the Members group chat model it doesnt seem to want to open. On Windows and Linux it works great

Screen.Recording.2024-01-12.at.1.46.20.PM.mov

@phillsatellite phillsatellite added the Changes requested When other dev or QA request a change label Jan 12, 2024
Copy link
Contributor

github-actions bot commented Jan 12, 2024

UI Automated Tests execution is complete! You can find the test results report here

@Jekrimo
Copy link
Contributor Author

Jekrimo commented Jan 12, 2024

Noticed a small bug that seems to be MacOS specific

When I try to open the Members group chat model it doesnt seem to want to open. On Windows and Linux it works great

Screen.Recording.2024-01-12.at.1.46.20.PM.mov

Should be fixed! I'm not sure why but I think what was happening is that the other_participants() was referencing active_participants somehow. I'm not super familiar with how group structs work but that's my guess. Lemme know if you run into any problems, thank youuuuuu

Copy link
Contributor

github-actions bot commented Jan 12, 2024

UI Automated Test Results Summary for MacOS/Windows

484 tests   432 ✅  2h 26m 55s ⏱️
 40 suites   52 💤
  3 files      0 ❌

Results for commit ee91fbf.

♻️ This comment has been updated with latest results.

@phillsatellite phillsatellite added linter failing Cargo Workflow (linter) failed on this PR and removed Changes requested When other dev or QA request a change labels Jan 12, 2024
@phillsatellite
Copy link
Contributor

Hey dude! So I went back in and pulled the latest but still getting some funny behavior

Its working great on Windows and Linux still but on Mac its about the same, 1on1 chats no longer have the group tooltip so thats working great but in group chats the members list still doesn't wanna open

Mac:

Mac.mov

Windows / Linux

Windows.mp4

@phillsatellite phillsatellite added the Changes requested When other dev or QA request a change label Jan 12, 2024
@stavares843
Copy link
Member

what phil mentioned also tried here and is the same 🔨

@Jekrimo
Copy link
Contributor Author

Jekrimo commented Jan 16, 2024

Hey dude! So I went back in and pulled the latest but still getting some funny behavior

Its working great on Windows and Linux still but on Mac its about the same, 1on1 chats no longer have the group tooltip so thats working great but in group chats the members list still doesn't wanna open

Mac:

Mac.mov
Windows / Linux

Windows.mp4

OY! Thank you for checking, I think I know what's up. If you are the creator of the group you get the edit button and not the modal, and vice versa if you are just added into the group, (not sure if you tried on accounts that were not admin of the group, it just messed me up for quite awhile so just putting it out there). This may be for not as Matt mentioned Saturday he may have an update for it anyways.

@github-actions github-actions bot removed Changes requested When other dev or QA request a change Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE linter failing Cargo Workflow (linter) failed on this PR labels Jan 16, 2024
@stavares843 stavares843 deleted the view-modal-for-groups branch January 16, 2024 20:38
@stavares843
Copy link
Member

closing after discussing with jeff as matt added this fix in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(ui): View Group tooltip appears in 1on1 DM
4 participants