Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LoadingIndicator): Added spinning loading indicator #1704

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

InfamousVague
Copy link
Contributor

What this PR does 📖

Screen.Recording.2024-01-12.at.1.42.16.PM.mov

Hopefully a CSS wizard will help make this 100% perfect but it's pretty close and can be used for now. In the video above you can see it in action when logging in.

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Jan 12, 2024
@phillsatellite phillsatellite added the linter failing Cargo Workflow (linter) failed on this PR label Jan 12, 2024
Copy link
Contributor

github-actions bot commented Jan 12, 2024

UI Automated Tests execution is complete! You can find the test results report here

@stavares843 stavares843 removed the linter failing Cargo Workflow (linter) failed on this PR label Jan 12, 2024
@phillsatellite phillsatellite added the Waiting for CI Waiting for at least one CI job to complete before merging label Jan 12, 2024
@InfamousVague InfamousVague merged commit 588108d into dev Jan 12, 2024
7 checks passed
@InfamousVague InfamousVague deleted the loading-indicator branch January 12, 2024 20:32
@github-actions github-actions bot removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE Waiting for CI Waiting for at least one CI job to complete before merging labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants