update(Keybind): Improve code let changing state just in the component #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Don't merge yet
UI Automated Test Results Summary for MacOS/Windows484 tests 432 ✅ 2h 12m 18s ⏱️ Results for commit 0fa0da1. ♻️ This comment has been updated with latest results. |
|
UI Automated Tests execution is complete! You can find the test results report here |
github-actions
bot
removed
the
Failed Automated Test
stavares843
approved these changes
Jan 16, 2024
phillsatellite
approved these changes
Jan 16, 2024
github-actions
bot
added
Failed Automated Test
dariusc93
approved these changes
Jan 17, 2024
dariusc93
added
Ready to Merge
phillsatellite
deleted the
improve-shortcut-component-actions-on-create-and-on-destroy
branch
github-actions
bot
removed
QA Tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
1. Just a PR to improve code and Pause Global Keybinds just inside the component, with on create and on destroy component functions now. Remove unnecessary code from other places.
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤