update(KeyBinds): Allow shortcuts to work just onkeydown, fixing firing twice #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Don't merge yet
UI Automated Test Results Summary for MacOS/Windows500 tests 448 ✅ 2h 34m 8s ⏱️ Results for commit 65c92c3. ♻️ This comment has been updated with latest results. |
|
UI Automated Tests execution is complete! You can find the test results report here |
phillsatellite
approved these changes
Jan 24, 2024
|
@lgmarchi was this PR apart of another PR or maybe been a duplicate? There were no changes reported after a recent merge. |
|
The other PR was to be merged after this one. So this is not necessary anymore. |
github-actions
bot
removed
Changes requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
1. Allow shortcuts to work just onkeydown, fixing firing twice
a. Now we don't need mroe debounce, and all shortcuts will fire just once onkeydown.
Which issue(s) this PR fixes 🔨
Special notes for reviewers 🗒️
Additional comments 🎤