-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(chat): Fix user tagging in messages #1765
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Don't merge yet
DO NOT MERGE
Missing dev review
Still needs to be reviewed by a dev
labels
Jan 25, 2024
github-actions
bot
added
the
linter failing
Cargo Workflow (linter) failed on this PR
label
Jan 25, 2024
dariusc93
reviewed
Jan 25, 2024
UI Automated Test Results Summary for MacOS/Windows491 tests 434 ✅ 2h 8m 4s ⏱️ Results for commit 90623ad. ♻️ This comment has been updated with latest results. |
UI Automated Tests execution is complete! You can find the test results report here |
github-actions
bot
added
the
missing fixing conflict
A conflict exists in current PR and needs resolution
label
Jan 25, 2024
Flemmli97
removed
the
missing fixing conflict
A conflict exists in current PR and needs resolution
label
Jan 26, 2024
phillsatellite
approved these changes
Jan 26, 2024
dariusc93
reviewed
Jan 29, 2024
github-actions
bot
added
Failed Automated Test
This PR is failing Luis's Appium test and needs revised
and removed
Failed Automated Test
This PR is failing Luis's Appium test and needs revised
labels
Jan 31, 2024
dariusc93
reviewed
Jan 31, 2024
dariusc93
approved these changes
Feb 1, 2024
dariusc93
added
Ready to Merge
This PR is ready to merge
and removed
Missing dev review
Still needs to be reviewed by a dev
Don't merge yet
DO NOT MERGE
labels
Feb 1, 2024
stavares843
added
Waiting for CI
Waiting for at least one CI job to complete before merging
and removed
QA Tested
QA has tested and approved
Ready to Merge
This PR is ready to merge
labels
Feb 1, 2024
stavares843
approved these changes
Feb 1, 2024
github-actions
bot
removed
the
Waiting for CI
Waiting for at least one CI job to complete before merging
label
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does 📖
HTML tags where escaped after the div indicating tags where added causing it to render the div as plain text.
This PR moves it after they are escaped but it comes with a caveat:
The process of tagging a user runs as follows:
User tags someone in their message using
@Name#ShortID
-> converted to@DID
.On receiving side did gets converted to
@Name
(and previously this was cached but its now not possible anymore).TBH though this caveat might just be a case of micro optimization.