Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(flags): fix flags on windows #1776

Merged
merged 4 commits into from
Jan 29, 2024
Merged

fix(flags): fix flags on windows #1776

merged 4 commits into from
Jan 29, 2024

Conversation

stavares843
Copy link
Member

What this PR does 📖

  • Fix flags on Windows using the images itself instead of emojis hardcoded

image

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Jan 29, 2024
@github-actions github-actions bot added the linter failing Cargo Workflow (linter) failed on this PR label Jan 29, 2024
@stavares843 stavares843 removed the linter failing Cargo Workflow (linter) failed on this PR label Jan 29, 2024
@phillsatellite phillsatellite added the Waiting for CI Waiting for at least one CI job to complete before merging label Jan 29, 2024
@phillsatellite phillsatellite added QA Tested QA has tested and approved and removed Waiting for CI Waiting for at least one CI job to complete before merging labels Jan 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 29, 2024 •
edited
Loading

UI Automated Tests execution is complete! You can find the test results report here

@stavares843 stavares843 merged commit 8272b7e into dev Jan 29, 2024
6 of 7 checks passed
@stavares843 stavares843 deleted the sara/fix-flags-windows branch January 29, 2024 20:17
@github-actions github-actions bot removed QA Tested QA has tested and approved Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels Jan 29, 2024
@stavares843 stavares843 mentioned this pull request Jan 29, 2024
Merged
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Jan 29, 2024
@stavares843 stavares843 removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees

@stavares843 stavares843

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stavares843 @phillsatellite