Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): Chatbar + edit focus and style #1930

Merged
merged 8 commits into from
Mar 26, 2024
Merged

Conversation

Flemmli97
Copy link
Collaborator

@Flemmli97 Flemmli97 commented Mar 19, 2024

What this PR does 📖

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Mar 19, 2024
Copy link
Contributor

github-actions bot commented Mar 19, 2024

UI Automated Test Results Summary for MacOS/Windows

511 tests   442 ✅  3h 11m 15s ⏱️
 45 suites   69 💤
  3 files      0 ❌

Results for commit 10bda5f.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 19, 2024

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot added the missing fixing conflict A conflict exists in current PR and needs resolution label Mar 19, 2024
@Flemmli97 Flemmli97 removed the missing fixing conflict A conflict exists in current PR and needs resolution label Mar 20, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 20, 2024
@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 20, 2024
@phillsatellite
Copy link
Contributor

@Flemmli97 When testing I tried using the up arrow to edit my most recent sent message but was having issues getting that to work

Screen.Recording.2024-03-21.at.12.36.08.PM.mov

@phillsatellite phillsatellite added the Changes requested When other dev or QA request a change label Mar 21, 2024
@Flemmli97
Copy link
Collaborator Author

my bad. i linked the wrong issue. it addresses #1564 (second point)

@Flemmli97 Flemmli97 removed the Changes requested When other dev or QA request a change label Mar 21, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 22, 2024
@stavares843 stavares843 removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Mar 22, 2024
@github-actions github-actions bot added Failed Automated Test This PR is failing Luis's Appium test and needs revised and removed Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Mar 22, 2024
@phillsatellite phillsatellite added the Waiting for CI Waiting for at least one CI job to complete before merging label Mar 25, 2024
@luisecm luisecm removed the Waiting for CI Waiting for at least one CI job to complete before merging label Mar 25, 2024
@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Mar 25, 2024
@dariusc93 dariusc93 removed the Missing dev review Still needs to be reviewed by a dev label Mar 25, 2024
@dariusc93 dariusc93 added Ready to Merge This PR is ready to merge and removed Don't merge yet DO NOT MERGE labels Mar 25, 2024
@stavares843 stavares843 added Waiting for CI Waiting for at least one CI job to complete before merging and removed QA Tested QA has tested and approved Ready to Merge This PR is ready to merge labels Mar 26, 2024
@stavares843
Copy link
Member

i've noticed if you cancel the edit the auto focus doesn't go automatically go the chat bar again

the same happens if you upload and cancel as well

Gravacao.do.ecra.2024-03-26.as.00.12.31.mov

but merging, can be improved later

macOS, m1

@stavares843 stavares843 merged commit d8209d1 into dev Mar 26, 2024
4 checks passed
@stavares843 stavares843 deleted the chatbar_edit_focus branch March 26, 2024 00:13
@github-actions github-actions bot removed the Waiting for CI Waiting for at least one CI job to complete before merging label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

task(chat): Various improvements for edit message
5 participants