Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(login): change ordering of account creation pages #1976

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

Flemmli97
Copy link
Collaborator

What this PR does 📖

  • Reorders the pages in account creation. Previously it went Password -> Create/Import -> Phrases -> Username.
    Now: Password -> Create/Import -> Username -> Phrases.

Which issue(s) this PR fixes 🔨

@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev labels Apr 15, 2024
@github-actions github-actions bot added the Failed Automated Test This PR is failing Luis's Appium test and needs revised label Apr 15, 2024
@phillsatellite phillsatellite added the QA Tested QA has tested and approved label Apr 15, 2024
Copy link
Contributor

UI Automated Test Results Summary for MacOS/Windows

13 tests   4 ✅  2m 39s ⏱️
 5 suites  3 💤
 3 files    3 ❌  3 🔥

For more details on these failures and errors, see this check.

Results for commit 065e43e.

Copy link
Contributor

UI Automated Tests execution is complete! You can find the test results report here

@stavares843 stavares843 merged commit 46d3d7d into dev Apr 17, 2024
6 of 10 checks passed
@stavares843 stavares843 deleted the login_pages_rework branch April 17, 2024 15:33
@github-actions github-actions bot removed QA Tested QA has tested and approved Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE Failed Automated Test This PR is failing Luis's Appium test and needs revised labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: seed generation & display should come after account creation
4 participants