Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(warp): Update dependency #1989

Merged
merged 4 commits into from
May 10, 2024
Merged

chore(warp): Update dependency #1989

merged 4 commits into from
May 10, 2024

Conversation

dariusc93
Copy link
Contributor

@dariusc93 dariusc93 commented May 9, 2024 •
edited
Loading

What this PR does 📖

  • Enable quic by default
  • use mut handle for Config
  • Migrate metadata to internal datastore
  • name subscribe functions to their new corresponding functions based on the trait name.

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

  • Network optimizations were done which should help with block exchanges
  • Quic is now enabled by default, and can be disabled by using --disable-quic flag.
    • Should help to improve hole punching

@dariusc93 dariusc93 self-assigned this May 9, 2024
@github-actions github-actions bot added Don't merge yet DO NOT MERGE Missing dev review Still needs to be reviewed by a dev Failed Automated Test This PR is failing Luis's Appium test and needs revised labels May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited
Loading

UI Automated Test Results Summary for MacOS/Windows

514 tests   434 ✅  3h 23m 38s ⏱️
 45 suites   80 💤
  3 files      0 ❌

Results for commit 1cbd82a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024

UI Automated Tests execution is complete! You can find the test results report here

@github-actions github-actions bot removed the Failed Automated Test This PR is failing Luis's Appium test and needs revised label May 10, 2024
@dariusc93 dariusc93 marked this pull request as ready for review May 10, 2024 17:59
@phillsatellite phillsatellite merged commit d7342d8 into dev May 10, 2024
6 of 7 checks passed
@phillsatellite phillsatellite deleted the warp-update branch May 10, 2024 18:09
@github-actions github-actions bot removed Missing dev review Still needs to be reviewed by a dev Don't merge yet DO NOT MERGE labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillsatellite phillsatellite phillsatellite approved these changes

@luisecm luisecm luisecm approved these changes

Assignees

@dariusc93 dariusc93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dariusc93 @luisecm @phillsatellite @stavares843