Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(button): hide button #382

Closed
wants to merge 6 commits into from
Closed

chore(button): hide button #382

wants to merge 6 commits into from

Conversation

stavares843
Copy link
Member

What this PR does 📖

Gravacao.do.ecra.2024-08-08.as.00.18.01.mov

@github-actions github-actions bot added the Missing dev review Two dev reviews are required on PR label Aug 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

Automated Test Results

failed  1 failed
passed  107 passed
flaky  1 flaky
skipped  15 skipped

Details

stats  124 tests across 20 suites
duration  12 minutes, 31 seconds
commit  317e26b

Failed tests

Automated Tests on Chrome Desktop › 01-pin-input.spec.ts › Create Account and Login Tests › A1, A9, A11 - Enter valid PIN redirects to Main Page

Flaky tests

Automated Tests on Chrome Desktop › 22-chats-tests.spec.ts › Chats Tests - Two instances › B1 - Send text message to remote user - Message is displayed on local and remote users

Skipped tests

Automated Tests on Chrome Desktop › 01-pin-input.spec.ts › Create Account and Login Tests › A12 - If incorrect pin is entered, error message should be displayed
Automated Tests on Chrome Desktop › 07-settings-profile.spec.ts › Settings Profile Tests › I9, I10 - User should be able to change username and see toast notification of change
Automated Tests on Chrome Desktop › 07-settings-profile.spec.ts › Settings Profile Tests › I22 - Clicking copy should copy the Recovery Phrase to the users clipboard
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K4 - Clicking OpenFolder should open the Fonts folder
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K8 - Clicking the moon button should change theme of the app from Dark to Light
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K10 - Themes folder button should open the themes folder
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K17 - Clicking Open Folder from Emoji Font section should open the Emoji Fonts folder
Automated Tests on Chrome Desktop › 09-settings-customizations.spec.ts › Settings Customization Tests › K20 - Clicking Open Folder from Default Profile Picture Style section should open the correct folder
Automated Tests on Chrome Desktop › 12-settings-extensions.spec.ts › Settings Extensions Tests › N2 - Clicking Explore should take user to Explore page
Automated Tests on Chrome Desktop › 12-settings-extensions.spec.ts › Settings Extensions Tests › N3 - Clicking Settings should take user to Settings page
Automated Tests on Chrome Desktop › 14-settings-gamepad.spec.ts › Settings Extensions Tests › Simulate gamepad left button press
Automated Tests on Chrome Desktop › 17-settings-network.spec.ts › Settings Network Tests › Validate Settings Network page is shown
Automated Tests on Chrome Desktop › 18-settings-about.spec.ts › Settings About Tests › R3 - Clicking Check for Updates should check for newest version of Uplink available
Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state
Automated Tests on Chrome Desktop › 24-files.spec.ts › Files Page Tests › F13 - Files and folders are still visible after logging out and login again

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024 •
edited
Loading

Playwright test execution is complete! You can find the test results report here

@phillsatellite
Copy link
Contributor

Hey Sara 👋 when I pulled this branch and did a new account it still displayed the Import Account option

Screen.Recording.2024-08-08.at.11.14.27.AM.mov

@phillsatellite phillsatellite added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Aug 8, 2024
@stavares843
Copy link
Member Author

oh was for the video please try again updated 😂

@stavares843 stavares843 removed the QA Requested Changes Changes need to be addressed, something is not working as expected. label Aug 8, 2024
@phillsatellite phillsatellite added the QA Approved PR has been tested by QA Team label Aug 8, 2024
@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Aug 8, 2024
@luisecm luisecm mentioned this pull request Aug 8, 2024
Closed
@luisecm
Copy link
Contributor

luisecm commented Aug 8, 2024

CI issue is "expected" since this test is validating the text contained in the import button that is being hidden:
image

Went ahead and added pr on testing repo:
Satellite-im/automated-tests-web#116

@phillsatellite phillsatellite removed the Failed Automated Test Failed Automated Tests CI label Aug 8, 2024
@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Aug 8, 2024
@phillsatellite phillsatellite removed the Failed Automated Test Failed Automated Tests CI label Aug 8, 2024
@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Aug 8, 2024
@stavares843 stavares843 removed the Failed Automated Test Failed Automated Tests CI label Aug 8, 2024
lgmarchi
lgmarchi requested changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@lgmarchi lgmarchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some changes.

src/lib/layouts/login/Entrypoint.svelte Outdated
@@ -18,6 +18,14 @@

let showAccounts = false
let showConfigureRelay = false

// Add a boolean variable to control the visibility of the button
let showButton: boolean = false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stavares843 This value will be false forever.

src/lib/layouts/login/Entrypoint.svelte Outdated
let showButton: boolean = false

// Function to toggle the visibility of the button (if needed)
function toggleButtonVisibility() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function has not been used.

src/lib/layouts/login/Entrypoint.svelte Outdated
// Add a boolean variable to control the visibility of the button
let showButton: boolean = false

// Function to toggle the visibility of the button (if needed)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of the function is very clear, we don't need comment here.

src/lib/layouts/login/Entrypoint.svelte Outdated
@@ -18,6 +18,14 @@

let showAccounts = false
let showConfigureRelay = false

// Add a boolean variable to control the visibility of the button
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of the variable is good, we don't need comments here.

@lgmarchi lgmarchi added the QA Requested Changes Changes need to be addressed, something is not working as expected. label Aug 9, 2024
@stavares843 stavares843 removed the Missing dev review Two dev reviews are required on PR label Aug 9, 2024
@stavares843 stavares843 added 📄 Draft PR is not ready yet and removed QA Approved PR has been tested by QA Team QA Requested Changes Changes need to be addressed, something is not working as expected. labels Aug 9, 2024
@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Aug 9, 2024
@stavares843 stavares843 closed this Aug 9, 2024
@stavares843 stavares843 deleted the sara/hide-button-import-flow-001 branch August 14, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgmarchi lgmarchi lgmarchi requested changes

@phillsatellite phillsatellite phillsatellite approved these changes

Assignees

@stavares843 stavares843

Labels
📄 Draft PR is not ready yet Failed Automated Test Failed Automated Tests CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stavares843 @phillsatellite @luisecm @lgmarchi