Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Chat): Fix chatbar messages to persist through different conversations #540

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

lgmarchi
Copy link
Collaborator

@lgmarchi lgmarchi commented Sep 11, 2024

What this PR does 📖

1. Fix chatbar messages to persist through different conversations

Screen.Recording.2024-09-11.at.16.18.26.mov

2. Put focus again on chatbar, after select an emoji, or send a sticker or gif

Screen.Recording.2024-09-11.at.17.43.34.mov

Which issue(s) this PR fixes 🔨

Special notes for reviewers 🗒️

Additional comments 🎤

@lgmarchi lgmarchi self-assigned this Sep 11, 2024
Copy link

github-actions bot commented Sep 11, 2024

Automated Test Results

failed  1 failed
passed  121 passed
skipped  1 skipped

Details

stats  123 tests across 17 suites
duration  18 minutes, 38 seconds
commit  c2991bb

Failed tests

Automated Tests on Chrome Desktop › 03-friends-two-instances.spec.ts › Two instances tests - Friends and Chats › H6, H19, B1 to B6, B16 and B17, B35 to B37 - Friend request happy path flow and then Chats Page basic send/receive text message flow

Skipped tests

Automated Tests on Chrome Desktop › 20-settings-developer.spec.ts › Settings Developer Tests › T4 - Clicking Clear State should clear users state

@github-actions github-actions bot added the Failed Automated Test Failed Automated Tests CI label Sep 11, 2024
Copy link

github-actions bot commented Sep 11, 2024

Playwright test execution is complete! You can find the test results report here

@luisecm
Copy link
Contributor

luisecm commented Sep 11, 2024

@lgmarchi Reviewed the CI test failing. It is related to the ui locator for chatbar input changing, but the testing passed manually. I went ahead and prepared the PR with changes required to tests here: Satellite-im/automated-tests-web#151, so you can ignore that failing test

@luisecm luisecm added the QA Approved PR has been tested by QA Team label Sep 11, 2024
@InfamousVague InfamousVague merged commit e5227e2 into dev Sep 11, 2024
2 of 3 checks passed
@InfamousVague InfamousVague deleted the fix-chatbar-message-persist branch September 11, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed Automated Test Failed Automated Tests CI QA Approved PR has been tested by QA Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improvement(chats): put cursor in chatbar again after picking up an emoi
3 participants