minor suggestions

Satellite-im · Jul 3, 2024 · db006d6 · db006d6
1 parent b47fe81
commit db006d6
Showing 1 changed file with 30 additions and 45 deletions.
diff --git a/cypress/e2e/15-settings-developer.cy.ts b/cypress/e2e/15-settings-developer.cy.ts
@@ -6,11 +6,19 @@ import settingsProfile from "./PageObjects/Settings/SettingsProfile";
 import settingsAbout from "./PageObjects/Settings/SettingsAbout";
 import settingsDeveloper from "./PageObjects/Settings/SettingsDeveloper";
 
+const DEV_MODE_URL = "/settings/developer";
+const ABOUT_URL = "/settings/about";
+const BLUE_BORDER_COLOR = "rgb(77, 77, 255)";
+
 describe("Settings - Developer Mode", () => {
-  const username =
-    faker.person.firstName() + faker.number.int({ min: 100, max: 10000 });
+  const username = faker.person.firstName() + faker.number.int({ min: 100, max: 10000 });
   const status = faker.lorem.sentence(3);
 
+  const openDevMode = () => {
+    settingsAbout.openDevMode();
+    cy.url().should("include", DEV_MODE_URL);
+  };
+
   beforeEach(() => {
     loginPinPage.loginWithPin("1234");
     authNewAccount.createRandomUser(username, status);
@@ -21,33 +29,26 @@ describe("Settings - Developer Mode", () => {
 
   it("T1, T2 - Clicking Exit Devmode should exit user out of Devmode", () => {
     // Open DevMode
-    settingsAbout.openDevMode();
-    cy.url().should("include", "/settings/developer");
+    openDevMode();
+    cy.url().should("include", DEV_MODE_URL);
 
     // Validate header and description texts
     settingsDeveloper.devModeSectionLabel.should("have.text", "Devmode");
-    settingsDeveloper.devModeSectionText.should(
-      "have.text",
-      "Disable devmode.",
-    );
+    settingsDeveloper.devModeSectionText.should("have.text", "Disable devmode.");
 
     // Click on Exit DevMode
     settingsDeveloper.devModeSectionButton.click();
     settingsDeveloper.devModeSectionButton.should("not.exist");
-    cy.url().should("include", "/settings/about");
+    cy.url().should("include", ABOUT_URL);
   });
 
   it("T3 - Clicking Load MockData should load all mock data throughout app", () => {
     // Open DevMode
-    settingsAbout.openDevMode();
-    cy.url().should("include", "/settings/developer");
+    openDevMode();
 
     // Validate header and description texts
     settingsDeveloper.loadMockSectionLabel.should("have.text", "Load Mock");
-    settingsDeveloper.loadMockSectionText.should(
-      "have.text",
-      "Loads mock data into state.",
-    );
+    settingsDeveloper.loadMockSectionText.should("have.text", "Loads mock data into state.");
 
     // Click on Load Mock
     settingsDeveloper.loadMockSectionButton.click();
@@ -63,72 +64,56 @@ describe("Settings - Developer Mode", () => {
   // Skipped since button is not performing any action now
   it.skip("T4 - Clicking Clear State should clear users state", () => {
     // Open DevMode
-    settingsAbout.openDevMode();
-    cy.url().should("include", "/settings/developer");
+    openDevMode();
+    cy.url().should("include", DEV_MODE_URL);
 
     // Validate header and description texts
     settingsDeveloper.clearStateSectionLabel.should("have.text", "Clear State");
-    settingsDeveloper.clearStateSectionText.should(
-      "have.text",
-      "Reset the application state.",
-    );
+    settingsDeveloper.clearStateSectionText.should("have.text", "Reset the application state.");
 
     // Click on Clear State
     settingsDeveloper.clearStateSectionButton.click();
   });
 
   it("T5 - Highlighted border should appear around Exit DevMode when clicked", () => {
     // Open DevMode
-    settingsAbout.openDevMode();
-    cy.url().should("include", "/settings/developer");
+    openDevMode();
+    cy.url().should("include", DEV_MODE_URL);
 
     // Focus on Exit DevMode
     settingsDeveloper.devModeSectionButton.focus();
 
     // Validate that the border color changes to blue
-    settingsDeveloper.devModeSectionButton.should(
-      "have.css",
-      "border-bottom-color",
-      "rgb(77, 77, 255)",
-    );
+    settingsDeveloper.devModeSectionButton.should("have.css", "border-bottom-color", BLUE_BORDER_COLOR);
   });
 
   it("T6 - Highlighted border should appear around Load MockData when clicked", () => {
     // Open DevMode
-    settingsAbout.openDevMode();
-    cy.url().should("include", "/settings/developer");
+    openDevMode();
+    cy.url().should("include", DEV_MODE_URL);
 
     // Click on Load Mock Data button
     settingsDeveloper.loadMockSectionButton.click();
 
     // Validate that the border color changes to blue
-    settingsDeveloper.loadMockSectionButton.should(
-      "have.css",
-      "border-bottom-color",
-      "rgb(77, 77, 255)",
-    );
+    settingsDeveloper.loadMockSectionButton.should("have.css", "border-bottom-color", BLUE_BORDER_COLOR);
   });
 
   it("T7 - Highlighted border should appear around Clear State when clicked", () => {
     // Open DevMode
-    settingsAbout.openDevMode();
-    cy.url().should("include", "/settings/developer");
+    openDevMode();
+    cy.url().should("include", DEV_MODE_URL);
 
     // Click on Clear State button
     settingsDeveloper.clearStateSectionButton.focus();
 
     // Validate that the border color changes to blue
-    settingsDeveloper.clearStateSectionButton.should(
-      "have.css",
-      "border-bottom-color",
-      "rgb(77, 77, 255)",
-    );
+    settingsDeveloper.clearStateSectionButton.should("have.css", "border-bottom-color", BLUE_BORDER_COLOR);
   });
 
   it("T8 - Clicking Test Voice State should open debug voice page", () => {
     // Open DevMode
-    settingsAbout.openDevMode();
-    cy.url().should("include", "/settings/developer");
+    openDevMode();
 
     // Validate header and description texts
     settingsDeveloper.testVoiceSectionLabel.should("have.text", "Test Voice");
@@ -140,4 +125,4 @@ describe("Settings - Developer Mode", () => {
     // Validate that the URL is redirected correctly
     cy.url().should("include", "/developer/debug/voice");
   });
-});
+});