Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(test): update test for screen share pr #194

Merged
merged 2 commits into from
Nov 19, 2024
Merged

update(test): update test for screen share pr #194

merged 2 commits into from
Nov 19, 2024

Conversation

luisecm
Copy link
Collaborator

@luisecm luisecm commented Nov 19, 2024

What this PR does 📖

  • Adding here small change required for this PR - feat(Call): Enable screen share on calls. UplinkWeb#863
  • Since currently Screen Share button changes to red when clicking on it, I have updated the css validation to assert that button changes to green when starting validation
  • This does not include yet any screen share tests

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@luisecm luisecm mentioned this pull request Nov 19, 2024
Merged
@luisecm luisecm merged commit a687678 into dev Nov 19, 2024
3 checks passed
@luisecm luisecm deleted the luis/stream-pr branch November 19, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@luisecm