Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(refactor): use base classes for settings and main pages #27

Merged
merged 1 commit into from
Jun 10, 2024
Merged

update(refactor): use base classes for settings and main pages #27

merged 1 commit into from
Jun 10, 2024

Conversation

luisecm
Copy link
Collaborator

@luisecm luisecm commented Jun 10, 2024

What this PR does 📖

  • Refactored Page Objects to use base classes for Settings and Main, in order to have in base classes the UI elements that are repeated along several pages in the app
  • Implemented refactored page objects across existing test specs
  • Added validation to settings inventory test to ensure that profile frame is added/removed successfully from settings profile page
  • Renamed settings inventory spec file for typo

Which issue(s) this PR fixes 🔨

  • Resolve #

Special notes for reviewers 🗒️

Additional comments 🎤

@luisecm luisecm merged commit 60ad1de into main Jun 10, 2024
4 checks passed
@luisecm luisecm deleted the luis/settings-cust branch June 10, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@luisecm luisecm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@luisecm