Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New CV UI - ContentView and ContentViewVersion Delete #1592

Merged
merged 1 commit into from
Oct 23, 2024
Merged

New CV UI - ContentView and ContentViewVersion Delete #1592

merged 1 commit into from
Oct 23, 2024

Conversation

damoore044
Copy link
Contributor

@damoore044 damoore044 commented Oct 9, 2024 •
edited
Loading

To support robottelo 16283.
Pulled in @sambible 's additions for New CV UI work in #939 and rebased

Includes fixes for Navigation failures seen in PRT, 'Version' tab, 'Publish' button, read_version_table() method,
and handle empty/no table in search() method, when there are no CVs in the Org

@damoore044 damoore044 mentioned this pull request Oct 15, 2024
Merged
@damoore044 damoore044 removed the 6.15.z label Oct 15, 2024
@damoore044 damoore044 mentioned this pull request Oct 15, 2024
Merged
@damoore044 damoore044 added the CherryPick PR needs CherryPick to previous branches label Oct 17, 2024
@damoore044 damoore044 marked this pull request as ready for review October 17, 2024 12:47
@damoore044 damoore044 requested review from sambible and a team October 17, 2024 12:48
@damoore044 damoore044 force-pushed the temp-prt-master branch 6 times, most recently from 98cb8b5 to a3fbe7c Compare October 17, 2024 17:23
@damoore044 damoore044 changed the title [Draft] Rebased New CV UI New CV UI - ContentView and ContentViewVersion Delete Oct 17, 2024
LadislavVasina1
LadislavVasina1 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@LadislavVasina1 LadislavVasina1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sambible
sambible approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK pending some of this being successfully exercised in the linked Robottelo PR. I'll merge once we see some promising results there.

@damoore044 damoore044 force-pushed the temp-prt-master branch 5 times, most recently from 4fa4671 to edb5f92 Compare October 23, 2024 14:30
@damoore044
Copy link
Contributor Author

PRT Result (Robottelo# 16283)

Build Number: 9117
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_contentview.py::test_positive_delete_cv_promoted_to_multi_env --external-logging
Test Result : ================== 1 passed, 32 warnings in 932.85s (0:15:32) ==================

@damoore044 damoore044 added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 23, 2024
@sambible sambible merged commit 85ac9fe into SatelliteQE:master Oct 23, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
@damoore044 @web-flow
New UI, CV and CVV Delete (#1592)
bb080a1 
(cherry picked from commit 85ac9fe)
@Satellite-QE Satellite-QE mentioned this pull request Oct 23, 2024
Merged
damoore044 added a commit that referenced this pull request Oct 23, 2024
@Satellite-QE @damoore044
New UI, CV and CVV Delete (#1592) (#1604)
129f020 
(cherry picked from commit 85ac9fe)

Co-authored-by: David Moore <109112035+damoore044@users.noreply.github.com>
@Satellite-QE Satellite-QE mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@vijaysawant vijaysawant vijaysawant approved these changes

@sambible sambible sambible approved these changes

Assignees

@damoore044 damoore044

Labels
6.16.z CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@damoore044 @sambible @vijaysawant @LadislavVasina1