Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ansible variable matcher_value locator #1607

Merged
merged 1 commit into from
Oct 29, 2024
Merged

update ansible variable matcher_value locator #1607

merged 1 commit into from
Oct 29, 2024

Conversation

amolpati30
Copy link
Contributor

@amolpati30 amolpati30 commented Oct 28, 2024 •
edited
Loading

Previously, the test case was failing because it couldn’t retrieve the locator. I updated the locator to ensure it fetches the correct value when creating the Ansible variable.

@amolpati30 amolpati30 marked this pull request as draft October 28, 2024 17:23
@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 432
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_assign_ansible_role_variable_on_host --external-logging
Test Result : ====== 1 failed, 10 deselected, 21 warnings, 1 error in 778.61s (0:12:58) ======

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Oct 28, 2024
@amolpati30
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_assign_ansible_role_variable_on_host

@Satellite-QE
Copy link
Contributor

PRT Result

Build Number: 433
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_ansible.py::TestAnsibleCfgMgmt -k test_positive_assign_ansible_role_variable_on_host --external-logging
Test Result : ========== 1 passed, 10 deselected, 22 warnings in 802.62s (0:13:22) ===========

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Oct 28, 2024
@amolpati30 amolpati30 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing 6.14.z 6.15.z 6.16.z Easy Fix :) labels Oct 29, 2024
@amolpati30 amolpati30 marked this pull request as ready for review October 29, 2024 06:24
@amolpati30 amolpati30 changed the title update ansible variable override function update ansible variable matcher_value locator Oct 29, 2024
@amolpati30 amolpati30 requested a review from a team October 29, 2024 06:39
shweta83
shweta83 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@shweta83 shweta83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@shubhamsg199 shubhamsg199 merged commit e4dd68a into SatelliteQE:master Oct 29, 2024
13 of 17 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
@amolpati30 @web-flow
update ansible variable override function (#1607)
b68325c 
(cherry picked from commit e4dd68a)
@Satellite-QE Satellite-QE mentioned this pull request Oct 29, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
@amolpati30 @web-flow
update ansible variable override function (#1607)
1223df5 
(cherry picked from commit e4dd68a)
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
@amolpati30 @web-flow
update ansible variable override function (#1607)
378a55a 
(cherry picked from commit e4dd68a)
This was referenced Oct 29, 2024
Merged
Merged
Satellite-QE added a commit that referenced this pull request Oct 29, 2024
@Satellite-QE
update ansible variable override function (#1607) (#1610)
1af60e6
Satellite-QE added a commit that referenced this pull request Oct 29, 2024
@Satellite-QE
update ansible variable override function (#1607) (#1609)
e55a12d
Satellite-QE added a commit that referenced this pull request Oct 29, 2024
@Satellite-QE
update ansible variable override function (#1607) (#1608)
c092f42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsg199 shubhamsg199 shubhamsg199 approved these changes

@shweta83 shweta83 shweta83 approved these changes

Assignees

@amolpati30 amolpati30

Labels
6.14.z 6.15.z 6.16.z AutoMerge_Cherry_Picked Automatically merge the PR is PRT and all checks are passing CherryPick PR needs CherryPick to previous branches Easy Fix :) PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amolpati30 @Satellite-QE @shweta83 @shubhamsg199