Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PF4 Search in Webhooks #914

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

lhellebr
Copy link
Contributor

@lhellebr lhellebr commented Aug 1, 2023

Switches Webhooks search to PF4. Now, the search doesn't work. It will work after this PR and #913 are merged.

@lhellebr lhellebr added 6.12.z CherryPick PR needs CherryPick to previous branches 6.13.z 6.14.z labels Aug 1, 2023
@lhellebr lhellebr requested a review from a team August 3, 2023 10:28
Copy link
Collaborator

@Gauravtalreja1 Gauravtalreja1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, just a qq, is PF4 search valid for all sat version you added labels for or just stream?

@omkarkhatavkar
Copy link

@lhellebr are you confirm that this change is on all satellite versions? or better to run the PRT and if it fails tells that which version it is not compatible

@omkarkhatavkar omkarkhatavkar merged commit 857f8c1 into SatelliteQE:master Aug 11, 2023
18 of 19 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
(cherry picked from commit 857f8c1)
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
(cherry picked from commit 857f8c1)
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
(cherry picked from commit 857f8c1)
mstrlc pushed a commit to mstrlc/airgun that referenced this pull request Aug 14, 2023
pondrejk pushed a commit that referenced this pull request Aug 14, 2023
(cherry picked from commit 857f8c1)
pondrejk pushed a commit that referenced this pull request Aug 14, 2023
(cherry picked from commit 857f8c1)
pondrejk pushed a commit that referenced this pull request Aug 14, 2023
(cherry picked from commit 857f8c1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.12.z 6.13.z 6.14.z CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants