Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a curated output flag for inventory #311

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

JacobCallahan
Copy link
Member

This provides a styled middle ground between the default minimal view and the much more verbose detailed view.
This also give us an opportunity to explore different output styling with rich.

fixes #306

This provides a styled middle ground between the default minimal view
and the much more verbose detailed view.
This also give us an opportunity to explore different output styling
with rich.

fixes SatelliteQE#306
@JacobCallahan JacobCallahan added the enhancement New feature or request label Sep 6, 2024
@JacobCallahan
Copy link
Member Author

And this is what it looks like

Screenshot from 2024-09-06 16-52-46

Copy link

@ehelms ehelms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love it if this was the default view, but i'll take it either way.

Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I would still like to discuss what data will be put in the table. I left one comment touching it.

Comment on lines +294 to +298
table.add_column("Id", justify="left", style="cyan", no_wrap=True)
table.add_column("Host", justify="left", style="magenta")
table.add_column("Provider", justify="left", style="green")
table.add_column("Action", justify="left", style="yellow")
table.add_column("OS", justify="left", style="blue")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add the name of the host to the table? There are quite a lot of cases when I need both, a hostname and the name of the host.

This ask might be a personal preference, however as I spoke with @lpramuk, he would also like to see what instance of the given provider was used to deploy the host.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep this table small, and not replicate the details view. So for now, I do want to stick with these columns, but look into ways to make it customizable in the future.

@JacobCallahan
Copy link
Member Author

@ehelms there's a good chance that I'll make this the default view in the future, but since this is coming out in a Z release, I don't want to break existing workflows.

@JacobCallahan JacobCallahan merged commit 87f0b56 into SatelliteQE:master Sep 9, 2024
4 checks passed
@JacobCallahan JacobCallahan deleted the less_details branch September 9, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide context when viewing broker inventory of what each machine is
3 participants