-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a curated output flag for inventory #311
Conversation
This provides a styled middle ground between the default minimal view and the much more verbose detailed view. This also give us an opportunity to explore different output styling with rich. fixes SatelliteQE#306
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love it if this was the default view, but i'll take it either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would still like to discuss what data will be put in the table. I left one comment touching it.
table.add_column("Id", justify="left", style="cyan", no_wrap=True) | ||
table.add_column("Host", justify="left", style="magenta") | ||
table.add_column("Provider", justify="left", style="green") | ||
table.add_column("Action", justify="left", style="yellow") | ||
table.add_column("OS", justify="left", style="blue") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add the name of the host to the table? There are quite a lot of cases when I need both, a hostname and the name of the host.
This ask might be a personal preference, however as I spoke with @lpramuk, he would also like to see what instance of the given provider was used to deploy the host.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to keep this table small, and not replicate the details view. So for now, I do want to stick with these columns, but look into ways to make it customizable in the future.
@ehelms there's a good chance that I'll make this the default view in the future, but since this is coming out in a Z release, I don't want to break existing workflows. |
This provides a styled middle ground between the default minimal view and the much more verbose detailed view.
This also give us an opportunity to explore different output styling with rich.
fixes #306