Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to the capsule upgrade playbook test #16321

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

pondrejk
Copy link
Contributor

Problem Statement

We are not really equipped to test the full capsule upgrade in the regular automation and I wouldn't say it's necessary. Meanwhile there came also an update playbook, that will be covered with #15863 (awaits packaging)

Solution

This pr changes the upgrade playbook tests to merely check that the playbook is around

Related Issues

@pondrejk pondrejk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z labels Sep 11, 2024
@pondrejk pondrejk self-assigned this Sep 11, 2024
@pondrejk pondrejk requested a review from a team as a code owner September 11, 2024 10:37
@pondrejk
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/api/test_remoteexecution.py -k upgrade

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8579
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/api/test_remoteexecution.py -k upgrade --external-logging
Test Result : =========== 1 passed, 2 deselected, 11 warnings in 622.21s (0:10:22) ===========

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 11, 2024
@lhellebr
Copy link
Contributor

Did it ever work in the original state? Why doesn't it anymore? Is this a regression testing-wise? Is there a plan to restore testing again? Why isn't it necessary to test it in your opinion? I know, a lot of questions :)

@pondrejk
Copy link
Contributor Author

pondrejk commented Sep 13, 2024

It did work in the sense that it triggered the playbook, but that didn't have a chance to actually complete the y-stream upgrade of capsule (for that we'd need an n-1 capsule + repos, etc). I suppose previously the playbook did "succeed" by doing nothing, likely the response from sat-maintain changed -- now when you try to upgrade to the same version you are on, you get failures

So I figure we could leave the y-stream scenario for upgrade pipeline, and in the regular run just check the playbook exists (this PR) + fully test z-stream capsule update, which is a newly added playbook (pr here #15863).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants