Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test_installer_modules_check from Upgrades #16505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove test_installer_modules_check from Upgrades #16505

wants to merge 1 commit into from

Conversation

lpramuk
Copy link
Contributor

@lpramuk lpramuk commented Sep 26, 2024 •
edited
Loading

Problem Statement

Test test_installer_modules_check is never going to pass in Upgrades Automation which bases off of Upgrade Templates where katello-answers.yaml was created since Satellite 6.10 times. Once you lock in to satellite scenario this answer file gets never changed.

I don't think that current test implementation understands how these answer files work.
Diffing between various scenarios answer files is useless.

Solution

Remove test_installer_modules_check from Upgrades Automation

Related Issues

@lpramuk lpramuk added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z labels Sep 26, 2024
@lpramuk lpramuk self-assigned this Sep 26, 2024
@lpramuk lpramuk requested a review from a team as a code owner September 26, 2024 12:36
@lpramuk
Copy link
Contributor Author

lpramuk commented Sep 26, 2024

I am considering an option to refactor the test rather than to remove it from Upgrades

@lpramuk
Copy link
Contributor Author

lpramuk commented Sep 27, 2024

trigger: test-robottelo
pytest: tests/foreman/installer/test_installer.py::test_installer_modules_check

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8829
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/installer/test_installer.py::test_installer_modules_check --external-logging
Test Result : ================== 1 passed, 9 warnings in 587.12s (0:09:47) ===================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lpramuk lpramuk

Labels
6.16.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpramuk @Satellite-QE