Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on dynaconf to render the config based on is_ipv6 setting #16886

Merged

Conversation

ogajduse
Copy link
Member

@ogajduse ogajduse commented Nov 7, 2024

Problem Statement

The REPOS section of the config contains -ipv4 hostnames despite the is_ipv6 setting being set to True. This happens because we are looping through the non-templatized/non-formatted configuration loaded by the dynaconf YAML loader:

all_settings = settings.loaded_by_loaders.items()

Since the REPOS config section contains several templates, either @format or @jinja, injecting a string containing -ipv4, and since our algorithm uses the raw config file value loaded by the YAML loader, we are not able to detect this case and change these URLs and hostnames to -ipv6.

Solution

The proposed solution is to shift to a different approach - from mutating settings by an algorithm in robottelo to creating a self-contained configuration structure and including IPv4 and IPv6 URLs and hostnames in the config. Based on the IS_IPV6 setting, templatize the value of the actual hostname/URL config field.

Related Issues

https://issues.redhat.com/browse/SAT-29304
satellite-jenkins!1545

@ogajduse ogajduse requested a review from a team as a code owner November 7, 2024 21:02
@ogajduse ogajduse marked this pull request as draft November 7, 2024 21:02
Copy link
Member

@JacobCallahan JacobCallahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. The concept looks more simple

@ogajduse ogajduse marked this pull request as ready for review November 11, 2024 15:18
@ogajduse
Copy link
Member Author

Switching the PR to a ready state. However, it still needs some testing.

@ogajduse ogajduse added CherryPick PR needs CherryPick to previous branches 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 labels Nov 11, 2024
@ogajduse
Copy link
Member Author

It was successfully tested in combination with satellite-jenkins!1545.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 6.15.z Introduced in or relating directly to Satellite 6.15 6.16.z Introduced in or relating directly to Satellite 6.16 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants