-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rely on dynaconf to render the config based on is_ipv6 setting #16886
Merged
JacobCallahan
merged 1 commit into
SatelliteQE:master
from
ogajduse:fix/ipv6-config-validation
Nov 14, 2024
Merged
Rely on dynaconf to render the config based on is_ipv6 setting #16886
JacobCallahan
merged 1 commit into
SatelliteQE:master
from
ogajduse:fix/ipv6-config-validation
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobCallahan
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. The concept looks more simple
Switching the PR to a ready state. However, it still needs some testing. |
ogajduse
added
CherryPick
PR needs CherryPick to previous branches
6.13.z
Introduced in or relating directly to Satellite 6.13
6.14.z
Introduced in or relating directly to Satellite 6.14
6.15.z
Introduced in or relating directly to Satellite 6.15
6.16.z
Introduced in or relating directly to Satellite 6.16
labels
Nov 11, 2024
pondrejk
approved these changes
Nov 12, 2024
It was successfully tested in combination with satellite-jenkins!1545. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 388a0ec)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 388a0ec)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 388a0ec)
This was referenced Nov 14, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
(cherry picked from commit 388a0ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.13.z
Introduced in or relating directly to Satellite 6.13
6.14.z
Introduced in or relating directly to Satellite 6.14
6.15.z
Introduced in or relating directly to Satellite 6.15
6.16.z
Introduced in or relating directly to Satellite 6.16
CherryPick
PR needs CherryPick to previous branches
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
The REPOS section of the config contains
-ipv4
hostnames despite theis_ipv6
setting being set toTrue
. This happens because we are looping through the non-templatized/non-formatted configuration loaded by the dynaconf YAML loader:robottelo/robottelo/utils/url.py
Line 46 in a79da44
Since the
REPOS
config section contains several templates, either@format
or@jinja
, injecting a string containing-ipv4
, and since our algorithm uses the raw config file value loaded by the YAML loader, we are not able to detect this case and change these URLs and hostnames to-ipv6
.Solution
The proposed solution is to shift to a different approach - from mutating settings by an algorithm in robottelo to creating a self-contained configuration structure and including IPv4 and IPv6 URLs and hostnames in the config. Based on the
IS_IPV6
setting, templatize the value of the actual hostname/URL config field.Related Issues
https://issues.redhat.com/browse/SAT-29304
satellite-jenkins!1545