Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] Fix Discovery Tests #16904

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #16605

Problem Statement

Discovery tests were failing with hussh backend as the shell didn't have stdout attribute and also because of a bug in hussh: JacobCallahan/Hussh#26

Solution

Updated the tests to exit the shell contextmanager and read shell.result.stdout. Also, because of the bug, we need to explicitly close the shell before exiting contextmanager.

Related Issues

(cherry picked from commit 41ec8b6)
@Satellite-QE Satellite-QE requested a review from a team as a code owner November 13, 2024 14:53
@Satellite-QE Satellite-QE added 6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA labels Nov 13, 2024
@Satellite-QE Satellite-QE requested a review from a team as a code owner November 13, 2024 14:53
@Satellite-QE Satellite-QE added the No-CherryPick PR doesnt need CherryPick to previous branches label Nov 13, 2024
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/api/test_discoveredhost.py --external-logging --include-onprem-provisioning -m on_premises_provisioning
provisioning: true
env:
    ROBOTTELO_server__deploy_arguments__deploy_rhel_version: '9'
    ROBOTTELO_server__deploy_arguments__deploy_sat_version: '6.16'
    ROBOTTELO_server__deploy_arguments__deploy_snap_version: '9.0'
    BROKER_SSH_BACKEND: hussh

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Nov 13, 2024
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 9352
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/api/test_discoveredhost.py --external-logging --include-onprem-provisioning -m on_premises_provisioning --external-logging --include-onprem-provisioning
Test Result : ===== 9 passed, 5 deselected, 1185 warnings, 1 error in 6081.11s (1:41:21) =====

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Nov 13, 2024
@Gauravtalreja1 Gauravtalreja1 merged commit b2e175d into 6.15.z Nov 13, 2024
15 of 18 checks passed
@Gauravtalreja1 Gauravtalreja1 deleted the cherry-pick-6.15.z-41ec8b6c020f44f27d2ec1645f2a5c4412ac315f branch November 13, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants