Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more convenient window creation method #3

Open
archiif opened this issue Aug 27, 2020 · 1 comment
Open

A more convenient window creation method #3

archiif opened this issue Aug 27, 2020 · 1 comment

Comments

@archiif
Copy link

archiif commented Aug 27, 2020

Right now, when you call vterm-extra-edit-command-in-new-buffer, the new buffer it creates will potentially occupy up an existing window which is fine, but the problem is that once you do a C-c C-c that window will be closed along with the editing buffer.
Is it possible to have a nicer window behavior? Maybe something like org-edit-src-code?

Edit: My dirty hack to fix this for now is by advising vterm-extra-edit-done with winner-undo:

(advice-add #'vterm-extra-edit-done :after #'winner-undo))
@Sbozzolo
Copy link
Owner

This is certainly a good point, but I am not sure how to implement it at the moment. I would like to see an example that is not as complicated as org-mode or helm.

(advice-add #'vterm-extra-edit-done :after #'winner-undo))

This would work in most cases, but what if you change the window configuration? E.g., you open another buffer to check documentaiton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants