Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ES6 module #5

Open
StefansArya opened this issue Jan 7, 2021 · 2 comments
Open

Implement ES6 module #5

StefansArya opened this issue Jan 7, 2021 · 2 comments

Comments

@StefansArya
Copy link
Member

Because this framework almost reach it's stable version and some fast build tools like snowpack/esbuild have showed up. I think it's the right time to implement ES6 module for this framework.

Feel free to contribute if you interested 😄

@StefansArya StefansArya added the good first issue Good for newcomers label Jan 7, 2021
@StefansArya
Copy link
Member Author

The ES6 module was implemented, but we still need to make it more efficient for the tree shaking.

@StefansArya
Copy link
Member Author

StefansArya commented Jan 19, 2021

Currently some module has circular dependency for:

- sf-model.js
- sf-component.js
- sf-space.js
- sf-model/*.js

I don't see any issues because of it and the circular dependency was expected.
But it may be fixed on the future.

If you want to remove the warning please add this config on your rollup.config.js:

export default {
  onwarn(warning, warn) {
    if (warning.code === 'CIRCULAR_DEPENDENCY') return;
    warn(warning);
  }
}

@StefansArya StefansArya removed the good first issue Good for newcomers label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant