Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#264) - refactor login module #267

Merged
merged 5 commits into from
Aug 14, 2024
Merged

๐Ÿ”€ :: (#264) - refactor login module #267

merged 5 commits into from
Aug 14, 2024

Conversation

audgns10
Copy link
Member

@audgns10 audgns10 commented Aug 13, 2024 •
edited
Loading

๐Ÿ’ก ๊ฐœ์š”

  • Login ๋ชจ๋“ˆ์—์„œ ๋ฆฌํŒฉํ† ๋ง์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์ด ์žˆ์Šต๋‹ˆ๋‹ค

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • Login ๋ชจ๋“ˆ์„ ๋ฆฌํŒฉํ† ๋ง ํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • ์ปดํฌ์ €๋ธ” ์•ˆ์—์„œ ์ƒํƒœ๋ฅผ ๊ด€๋ฆฌํ•˜๋Š” ๊ฒƒ์„ ViewModel์—์„œ SavedStateHandle์„ ์‚ฌ์šฉํ•˜์—ฌ ๊ด€๋ฆฌํ•  ์ˆ˜ ์žˆ๋„๋ก ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • ์ƒํƒœ ํ˜ธ์ด์ŠคํŒ…์„ ์‚ฌ์šฉํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • ์ปดํฌ์ €๋ธ”์—์„œ remember๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์„ ViewModel์œผ๋กœ ์˜ฎ๊ธฐ๊ธฐ ์–ด๋ ค์šด ๊ฒƒ์„ rememberSaveable์„ ์‚ฌ์šฉํ•˜์—ฌ ๋ณด๋‹ค ์•ˆ์ „ํ•˜๊ฒŒ ๊ด€๋ฆฌํ• . ์ˆ˜ ์žˆ๋„๋ก ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • ์ฝ”๋“œ ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • ๊ตฌ์กฐ ๋ถ„ํ•ด ์„ ์–ธ์„ ์‚ฌ์šฉํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • isTextStatus๋ฅผ ์‚ญ์ œํ•˜๊ณ  email ์ƒํƒœ๋ฅผ ์ง์ ‘ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๋„๋ก ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • isNullOrBlank()๋กœ ๋˜์–ด์žˆ๋Š” email์€ String ๋ฌธ์ž์—ด ์ด๊ธฐ๋•Œ๋ฌธ์— Null ๊ฐ’์ด ๋  ์ˆ˜ ์—†์œผ๋ฏ€๋กœ isBlank()๋กœ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • Modifier์„ modifier์ธ์ž๋กœ ๋ฐ›์•„์„œ ์‚ฌ์šฉํ•˜๋„๋ก ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค

๐Ÿ”€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • refactor LoginScreen
  • refactor AuthViewModel

@audgns10 audgns10 added 2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ - ์ค‘ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง labels Aug 13, 2024
@audgns10 audgns10 self-assigned this Aug 13, 2024
@audgns10 audgns10 linked an issue Aug 13, 2024 that may be closed by this pull request
Feature -> Login ๋ชจ๋“ˆ์— ๋ฆฌํŒฉํ† ๋ง์ด ํ•„์š”ํ•œ ๋ถ€๋ถ„์ด์žˆ์Šต๋‹ˆ๋‹ค #264
Closed
@audgns10 audgns10 merged commit 4a865ad into develop Aug 14, 2024
1 check passed
@audgns10 audgns10 deleted the refactor/264-refactor-login-module branch August 14, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjdcksdn wjdcksdn wjdcksdn approved these changes

@diejdkll diejdkll diejdkll approved these changes

@Chaejongin12 Chaejongin12 Awaiting requested review from Chaejongin12

Assignees

@audgns10 audgns10

Labels
2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ - ์ค‘ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Milestone
No milestone
3 participants
@audgns10 @diejdkll @wjdcksdn