Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸ”€ :: (#276) - refactor student activity module #277

Merged
merged 6 commits into from
Aug 20, 2024
Merged

πŸ”€ :: (#276) - refactor student activity module #277

merged 6 commits into from
Aug 20, 2024

Conversation

audgns10
Copy link
Member

πŸ’‘ κ°œμš”

  • student-activity λͺ¨λ“ˆμ— λ¦¬νŒ©ν† λ§μ΄ ν•„μš”ν•œ 뢀뢄듀이 μ‘΄μž¬ν•©λ‹ˆλ‹€

πŸ“ƒ μž‘μ—…λ‚΄μš©

  • student-activity λͺ¨λ“ˆμ„ λ¦¬νŒ©ν† λ§μ„ ν•˜μ˜€μŠ΅λ‹ˆλ‹€
    • Modifierλ₯Ό 인자둜 λ°›μ•„μ„œ μ‚¬μš©ν•  수 μžˆλ„λ‘ μ½”λ“œ 컨벀이 μ§€μΌœμ§€μ§€ μ•Šμ€ 뢀뢄을 μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€
    • ꡬ쑰 λΆ„ν•΄ 선언을 μ‚¬μš©ν•˜λ©΄ 더 효율적으둜 처리λ₯Ό ν•  수 μžˆλŠ” 뢀뢄을 μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€
    • by ν‚€μ›Œλ“œλ₯Ό μ‚¬μš©ν•˜μ˜€μŠ΅λ‹ˆλ‹€
    • Composableμ—μ„œ μƒνƒœ 관리λ₯Ό remember둜 ν•˜κ³  μžˆλŠ” λΆ€λΆ„ μ€‘μ—μ„œ viewModelμ—μ„œ SavedStateHandle둜 처리λ₯Ό ν•΄μ£Όλ©΄ 쒋을 것 같은 뢀뢄을 viewModelμ—μ„œ 관리할 수 μžˆλ„λ‘ μˆ˜μ •μ„ ν•˜μ˜€μŠ΅λ‹ˆλ‹€
    • Composable μ•ˆμ— rememberλ₯Ό μ‚¬μš©ν•˜μ—¬ 관리λ₯Ό ν•΄μ•Όν•œλ‹€λ©΄ rememberSaveable을 μ‚¬μš©ν•˜μ—¬ μ•ˆμ „μ„±μ„ 높일 수 μžˆλ„λ‘ μˆ˜μ •ν•˜μ˜€μŠ΅λ‹ˆλ‹€
    • μƒνƒœ ν˜Έμ΄μŠ€νŒ…(State Hoisting)을 ν•˜μ˜€μŠ΅λ‹ˆλ‹€

πŸ”€ 변경사항

  • refactor StudentActivityViewModel
  • refactor AddActivityScreen
  • refactor ActivityDetailSettingScreen
  • refactor StudentActivityScreen
  • refactor ActivityDetailScreen

πŸ™‹β€β™‚οΈ μ§ˆλ¬Έμ‚¬ν•­

  • ν•΄λ‹Ή prμ—μ„œ μ΄μƒν•œ 뢀뢄이 μžˆλ‹€λ©΄ Comment둜 κ³΅κ²©ν•΄μ£Όμ„Έμš”!

@audgns10 audgns10 added 2️⃣ Priority: Medium μš°μ„ μˆœμœ„ - 쀑 ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§ labels Aug 20, 2024
@audgns10 audgns10 self-assigned this Aug 20, 2024
@audgns10 audgns10 linked an issue Aug 20, 2024 that may be closed by this pull request
feature -> student-activity λͺ¨λ“ˆμ— λ¦¬νŒ©ν† λ§μ΄ ν•„μš”ν•œ 뢀뢄이 μ‘΄μž¬ν•©λ‹ˆλ‹€ #276
Closed
diejdkll
diejdkll reviewed Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@diejdkll diejdkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hiltViewModel 뢀뢄에 λ‹€ contextλ₯Ό μΆ”κ°€ν•œκ±° 같은데 μ„œλ‘œκ°„μ— κ³΅μœ ν•  뢀뢄이 μƒκ²¨μ„œ κ·ΈλŸ°κ±΄κ°€μš”?

audgns10
audgns10 commented Aug 20, 2024
View reviewed changes
Copy link
Member Author

@audgns10 audgns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사싀 λ”°λ‘œ 생각은 ν•˜μ§€ μ•Šκ³  λ‹€ λ„£μ—ˆλ˜ 것 κ°™μŠ΅λ‹ˆλ‹€ μˆ˜μ •ν•˜κ² μŠ΅λ‹ˆλ‹€

audgns10
audgns10 commented Aug 20, 2024
View reviewed changes
Copy link
Member Author

@audgns10 audgns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b407142

@diejdkll

λ¦¬λ·°λ°˜μ˜ν–ˆμŠ΅λ‹ˆλ‹€!

@audgns10 audgns10 merged commit 378ef50 into develop Aug 20, 2024
1 check passed
@audgns10 audgns10 deleted the refactor/276-refactor-student-activity-module branch August 20, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diejdkll diejdkll diejdkll approved these changes

@wjdcksdn wjdcksdn wjdcksdn approved these changes

@Chaejongin12 Chaejongin12 Awaiting requested review from Chaejongin12

Assignees

@audgns10 audgns10

Labels
2️⃣ Priority: Medium μš°μ„ μˆœμœ„ - 쀑 ♻️ Refactor μ½”λ“œ λ¦¬νŒ©ν† λ§
Projects
None yet
Milestone
No milestone
3 participants
@audgns10 @diejdkll @wjdcksdn