Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#293) Publishing Inquiry Screen #296

Merged
merged 24 commits into from
Sep 11, 2024
Merged

๐Ÿ”€ :: (#293) Publishing Inquiry Screen #296

merged 24 commits into from
Sep 11, 2024

Conversation

Chaejongin12
Copy link
Collaborator

@Chaejongin12 Chaejongin12 commented Sep 11, 2024 •
edited
Loading

๐Ÿ’ก ๊ฐœ์š”

๋ฌธ์˜ ์‚ฌํ•ญ ํŽ˜์ด์ง€๋ฅผ ์ž‘์—…ํ•ด์•ผํ•จ.

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

๋ˆ„๋ฝ๋๋˜ ๋ฌธ์˜ ์‚ฌํ•ญ ํŽ˜์ด์ง€๋ฅผ ํผ๋ธ”๋ฆฌ์‹ฑํ–ˆ์Šต๋‹ˆ๋‹ค.

2024-09-11.11.57.15.mov

๋ฌธ์˜ ์‚ฌํ•ญ ๋„ค๋น„๊ฒŒ์ด์…˜์„ ๋ฏธ๋ฆฌ ์„ธํŒ…ํ•ด๋†จ์Šต๋‹ˆ๋‹ค.
๋ฌธ์˜ ์‚ฌํ•ญ ViewModel์„ ๋ฏธ๋ฆฌ ์„ธํŒ…ํ•ด๋†จ์Šต๋‹ˆ๋‹ค.

๐Ÿ”€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

BitgoeulCheckbox์˜ isChecked๋ฅผ ๋‚ด๋ถ€์—์„œ ๊ด€๋ฆฌํ•˜๊ฒŒ๋” ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.
LectureFilterBottomSheet๋ฅผ ์‚ญ์ œํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ™‹โ€โ™‚๏ธ ์งˆ๋ฌธ์‚ฌํ•ญ

์ œ๊ฐ€ ์ž˜๋ชป ๊ตฌํ˜„ํ•œ ๋ถ€๋ถ„์ด ์žˆ๊ฑฐ๋‚˜ ์ƒํƒœ๊ด€๋ฆฌ๋ถ€๋ถ„์—์„œ ์•„์‰ฌ์šด๊ฒŒ ์žˆ๋‹ค๋ฉด ๋ฆฌ๋ทฐ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

๋˜ํ•œ ์ž„์‹œ๋กœ CheckBox์˜ ๋‚ด๋ถ€์—์„œ isChecked๋ฅผ ๊ด€๋ฆฌํ•˜๊ฒŒ๋” ์„ค์ •ํ•ด๋†“์•˜๋Š”๋ฐ ์™ธ๋ถ€ Screen์—์„œ๋ถ€ํ„ฐ ์ƒํƒœ๋ฅผ ์ฃผ์ž…๋ฐ›๋Š”๊ฒŒ ์Šคํ…Œ์ดํŠธ ํ˜ธ์ด์ŠคํŒ… ์ธก๋ฉด์—์„œ ๋” ์ข‹์•„ ๋ณด์ด๋Š”๋ฐ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋Š”์ง€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค.

@Chaejongin12
โœจ:: ๋ฌธ์˜์‚ฌํ•ญ ๋ชจ๋“ˆ ์ƒ์„ฑ
3aa76fd
@Chaejongin12
โœจ:: G2 ์ƒ‰์ƒ FilterIcon ์ถ”
765ba7c
@Chaejongin12
โœจ:: G2 ์ƒ‰์ƒ FilterIcon์„ Content๋กœ ํ•˜๋Š” Button ์ถ”๊ฐ€
0c87c1a
@Chaejongin12
โœจ:: G2 ์ƒ‰์ƒ FilterIcon์„ Content๋กœ ํ•˜๋Š” Button ์ถ”๊ฐ€
790b0da
@Chaejongin12
โœจ:: strings.xml ๋ฌธ์ž์—ด ์ถ”๊ฐ€
51b3680
@Chaejongin12
โœจ:: PositiveTag ์ƒ์„ฑ
65136f6
@Chaejongin12
โœจ:: NegativeTag ์ƒ์„ฑ
929bd23
@Chaejongin12
โœจ:: G2 ์ƒ‰์ƒ Icon svg ์ถ”๊ฐ€
e39aafe
@Chaejongin12
โœจ:: FilterDialog ์ƒ์„ฑ
7c51aea
@Chaejongin12
โœจ:: ๋ฌธ์˜์‚ฌํ•ญ ๋ชจ๋“ˆ ์ƒ์„ฑ
809add8
@Chaejongin12
โœจ:: ๋ฌธ์˜์‚ฌํ•ญ ๋ชจ๋“ˆ ์ƒ์„ฑ
da67226
@Chaejongin12
โœจ:: InquiryViewModel ์„ธ
82e7fab
@Chaejongin12
โœจ:: InquiryScreen(๋ฌธ์˜ ์‚ฌํ•ญ ํŽ˜์ด์ง€) ์ƒ
252f458
@Chaejongin12
โœจ:: Navigation ์„ธํŒ…
de16bc5
@Chaejongin12
โœจ:: InquiryList(๋ฌธ์˜ ์‚ฌํ•ญ ๋ฆฌ์ŠคํŠธ) ์ƒ์„ฑ
27f864a
@Chaejongin12
โœจ:: InquiryFilterButton(๋ฌธ์˜ ์‚ฌํ•ญ ํ•„ํ„ฐ ๋ฒ„ํŠผ) ์ƒ์„ฑ
3169366
@Chaejongin12
โœจ:: InquiryDetailScreen(๋ฌธ์˜ ์‚ฌํ•ญ ์„ธ๋ถ€ ํŽ˜์ด์ง€) ์„ธํŒ…
ced61a8
@Chaejongin12
โœจ:: InquiryCard(๋ฌธ์˜ ์‚ฌํ•ญ ์•„์ดํ…œ) ์ƒ์„ฑ
b2cfe39
@Chaejongin12
โ™ป๏ธ:: ์ž˜๋ชป ์ง€์ •๋œ lineHeight ์ˆ˜
bb41586
@Chaejongin12
โ™ป๏ธ:: BitGoeulCheckBox isChecked ๋‚ด๋ถ€ ๊ด€๋ฆฌ๋กœ ๋ณ€๊ฒฝ
6bb8a35
@Chaejongin12
๐Ÿ”ฅ:: LectureFilterBottomSheet(๊ฐ•์˜ ํ•„ํ„ฐ ๋ฐ”ํ…€์‹œํŠธ)๋ฅผ ๋”์ด์ƒ ์‚ฌ์šฉํ•˜์ง€ ์•Š๊ธฐ์— ์‚ญ์ œ
dc7f831
@Chaejongin12
โ™ป๏ธ :: BitGoeulCheckBox ๋ˆ„๋ฝ๋œ isChecked ๊ฐ’ ๋ณ€๊ฒฝ ๋กœ์ง ์ถ”๊ฐ€
267cea6 
:: BitGoeulCheckBox ๋ˆ„๋ฝ๋œ isChecked ๊ฐ’ ๋ณ€๊ฒฝ ๋กœ์ง ์ถ”๊ฐ€
@Chaejongin12
โ™ป๏ธ :: isChecked์˜ ๊ฐ’์„ ๋ฐ”๋กœ ๋ฐ˜ํ™˜ํ•˜๋„๋ก ๋ณ€๊ฒฝ
ac790dd 
:: isChecked์˜ ๊ฐ’์„ ๋ฐ”๋กœ ๋ฐ˜ํ™˜ํ•˜๋„๋ก ๋ณ€๊ฒฝ
@Chaejongin12 Chaejongin12 linked an issue Sep 11, 2024 that may be closed by this pull request
๋ฌธ์˜์‚ฌํ•ญ ์Šคํฌ๋ฆฐ ํผ๋ธ”๋ฆฌ์‹ฑ #293
Closed
diejdkll
diejdkll approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@diejdkll diejdkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์™ธ๋ถ€์—์„œ ๋„˜๊ฒจ์ฃผ๋Š”๊ฒŒ ๋” ์ข‹์•„๋ณด์—ฌ์š”

@Chaejongin12
โ™ป๏ธ :: ํ˜ธ์ด์ŠคํŒ…์„ ์œ„ํ•œ Check ์ƒํƒœ๋ฅผ ์™ธ๋ถ€์—์„œ ์ฃผ์ž…ํ•˜๋Š” ํ˜•์‹์œผ๋กœ ๋ณ€๊ฒฝ
d21f46b 
 :: ํ˜ธ์ด์ŠคํŒ…์„ ์œ„ํ•œ Check ์ƒํƒœ๋ฅผ ์™ธ๋ถ€์—์„œ ์ฃผ์ž…ํ•˜๋Š” ํ˜•์‹์œผ๋กœ ๋ณ€๊ฒฝ
audgns10
audgns10 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@audgns10 audgns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@Chaejongin12 Chaejongin12 merged commit 682d2cf into develop Sep 11, 2024
1 check passed
@Chaejongin12 Chaejongin12 deleted the feature/#293_publishing_-inquiry_screen branch September 11, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@audgns10 audgns10 audgns10 approved these changes

@wjdcksdn wjdcksdn wjdcksdn approved these changes

@diejdkll diejdkll diejdkll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๋ฌธ์˜์‚ฌํ•ญ ์Šคํฌ๋ฆฐ ํผ๋ธ”๋ฆฌ์‹ฑ
4 participants
@Chaejongin12 @diejdkll @wjdcksdn @audgns10