Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI to build SVGs with images embedded #31

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Rongronggg9
Copy link
Contributor

It should help fix the "CORS" (actually CSP, not CORS) issue mentioned in #30 (comment).

Preview: https://github.com/Rongronggg9/github-profile-achievements/tree/dist

It is believed to be the only solution to work around the CSP issue since it is chosen by opencollective to render user avatars in contributor tables.

@Schweinepriester
Copy link
Owner

Thank you for the PR and the inspiration!
But it will probably some time before I merge this if at all, because the proper SVGs (not the test ones) will take quiet a bit of hand massaging to make them nice. Because of this so far I had thought about doing the base64 conversion "manually" or maybe linking to the images in this repo (unlikely).
But maybe I'll do an intermediate step and having an action like this do the last one… we'll see!

@Rongronggg9
Copy link
Contributor Author

Sure. Looking forward to the finished SVGs. The current "testing" ones are already impressive for me :)

Copy link

@paulbull704 paulbull704 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know whats going on here.paul

Copy link

@Lymengchun Lymengchun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@Lymengchun

This comment was marked as spam.

@camerondevuk

This comment was marked as spam.

@akirataguchi115
Copy link

@Schweinepriester Any chance to remove and block some of these messages and users? 🥲

@CHARLLYS97
Copy link

O que está havendo ?

Copy link

@arifpro arifpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like everything good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants