Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate requirements-inspector-service to github #3

Merged
merged 16 commits into from
Nov 19, 2024

Conversation

SebastianScheidegger
Copy link
Contributor

@SebastianScheidegger SebastianScheidegger commented Nov 7, 2024

Proposed changes

Migrate repository to github

Checklist

Before creating a PR, run through this checklist and mark each as complete:

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation

@SebastianScheidegger SebastianScheidegger marked this pull request as ready for review November 7, 2024 12:59
@SebastianScheidegger SebastianScheidegger requested review from a team as code owners November 7, 2024 12:59
@ariwk
Copy link
Collaborator

ariwk commented Nov 8, 2024

@SebastianScheidegger is it possible we implemented unittest to reach code coverage >80%?

@ariwk
Copy link
Collaborator

ariwk commented Nov 8, 2024

@SebastianScheidegger please comment the security hotspot founding on sonarcloud that is not a problem for us and why it is not a problem

Copy link
Collaborator

@ariwk ariwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonarcloud prblems must be fixed

allowlist_external in tox and disable test logging
Test sonadcloud with test_service manually
…b' of github.com:SchweizerischeBundesbahnen/polarion-requirements-inspector-service into feature/migrate-requirements-inspector-service-to-github
…-requirements-inspector-service into feature/migrate-requirements-inspector-service-to-github
@ariwk ariwk enabled auto-merge (squash) November 19, 2024 13:54
@ariwk ariwk merged commit 0b677d7 into main Nov 19, 2024
9 checks passed
@ariwk ariwk deleted the feature/migrate-requirements-inspector-service-to-github branch November 19, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants