fix: refactoring + error handling

Refs: #69
SchweizerischeBundesbahnen · Sep 20, 2024 · 39c9c19 · 39c9c19
1 parent 0a38ace
commit 39c9c19
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/app/SvgUtils.py b/app/SvgUtils.py
@@ -119,16 +119,14 @@ def convert_svg_to_png(width, height, png_filepath, svg_filepath):
 
     try:
         result = subprocess.run(command)
+        if result.returncode != 0:
+            logging.error(f"Error converting SVG to PNG, return code = {result.returncode}")
+            return False
+        return True
     except Exception as e:
         logging.error(f"Failed to convert SVG to PNG: {e}")
         return False
 
-    if result.returncode != 0:
-        logging.error(f"Error converting SVG to PNG, return code = {result.returncode}")
-        return False
-
-    return True
-
 
 # Read the PNG file and clean up the temporary file
 def read_and_cleanup_png(png_filepath):