Modernize landingpage #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 16, 2023
Closed
bpedersen2
requested review from
nitrosx,
garethcmurphy,
dylanmcreynolds,
minottic and
jekabs-karklins
bpedersen2
force-pushed
the
modernize-landingpage
branch
3 times, most recently
from
4f5599d to
ded7341
Compare
bpedersen2
force-pushed
the
modernize-landingpage
branch
from
ded7341 to
de52b29
Compare
This was referenced Nov 17, 2023
|
Should update README to reflect the new versions used |
Use the same theme system as the scicat frontend
Reflect the new requirements for the landing page server
bpedersen2
force-pushed
the
modernize-landingpage
branch
from
b9c64c5 to
e8b68d8
Compare
…gular Bumps [webpack-dev-middleware](https://github.com/webpack/webpack-dev-middleware) to 6.1.2 and updates ancestor dependency [@angular-devkit/build-angular](https://github.com/angular/angular-cli). These dependencies need to be updated together. Updates `webpack-dev-middleware` from 5.3.0 to 6.1.2 - [Release notes](https://github.com/webpack/webpack-dev-middleware/releases) - [Changelog](https://github.com/webpack/webpack-dev-middleware/blob/v6.1.2/CHANGELOG.md) - [Commits](webpack/webpack-dev-middleware@v5.3.0...v6.1.2) Updates `@angular-devkit/build-angular` from 13.3.7 to 17.3.2 - [Release notes](https://github.com/angular/angular-cli/releases) - [Changelog](https://github.com/angular/angular-cli/blob/main/CHANGELOG.md) - [Commits](angular/angular-cli@13.3.7...17.3.2) --- updated-dependencies: - dependency-name: webpack-dev-middleware dependency-type: indirect - dependency-name: "@angular-devkit/build-angular" dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
|
I tried in another project to upgrade to angular 17 from 15 and the materials update was a mess. Does this work fine? is the rendering/style still ok? |
|
Looks OK to me in our test instance |
|
|
minottic
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize the landing page service:
Tests included/Docs Updated?
Extra Information/Screenshots